Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete autocomplete namespace #57187

Merged
merged 3 commits into from
Feb 10, 2020
Merged

Delete autocomplete namespace #57187

merged 3 commits into from
Feb 10, 2020

Conversation

lizozom
Copy link
Contributor

@lizozom lizozom commented Feb 10, 2020

Summary

Part of #56881

This PR applies the proposed resolution for #52374, trying to balance code readability, API discoverability, DX and documentation generation using ApiExtractor, on data\autocomplete

The result is deleting the autocomplete namespace, as its used mostly for exporting types.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@lizozom lizozom requested review from a team as code owners February 10, 2020 11:38
@lizozom lizozom self-assigned this Feb 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lizozom
Copy link
Contributor Author

lizozom commented Feb 10, 2020

retest

@lizozom lizozom mentioned this pull request Feb 10, 2020
Closed
11 tasks
@lizozom lizozom changed the title Delete autocomplete namespace (as its used mostly for expporting types) Delete autocomplete namespace Feb 10, 2020
ppisljar
ppisljar approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@ppisljar ppisljar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

dgieselaar
dgieselaar approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@dgieselaar dgieselaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APM changes LGTM

weltenwort
weltenwort approved these changes Feb 10, 2020
View reviewed changes
Copy link
Member

@weltenwort weltenwort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

infra changes LGTM

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@lizozom lizozom merged commit 18a76c0 into elastic:master Feb 10, 2020
lizozom pushed a commit to lizozom/kibana that referenced this pull request Feb 10, 2020
Delete autocomplete namespace (elastic#57187)
92899ef 
* Delete autocomplete namespace (as its used mostly for expporting types)

* Make prefix consistent
This was referenced Feb 10, 2020
Merged
Merged
lizozom pushed a commit that referenced this pull request Feb 10, 2020
[7.x] Delete autocomplete namespace (#57187) (#57213)
d2c482a 
* Delete autocomplete namespace (#57187)

* Delete autocomplete namespace (as its used mostly for expporting types)

* Make prefix consistent

* Fix TS error on master
gmmorris added a commit to gmmorris/kibana that referenced this pull request Feb 11, 2020
@gmmorris
Merge branch 'master' into alerting/alert-instances
91bd390 
* master: (34 commits)
  [Index management] Server-side NP ready (elastic#56829)
  Webhook action - make user and password secrets optional (elastic#56823)
  [DOCS] Removes reference to IRC (elastic#57245)
  [Monitoring] NP migration: Local angular module (elastic#51823)
  [SIEM] Adds ECS link to help menu (elastic#57104)
  Ensure http interceptors are shares across lifecycle methods (elastic#57150)
  [Remote clusters] Migrate server code out of legacy (elastic#56781)
  fixes render bug in alert list (elastic#57152)
  siem 7.6 updates (elastic#57169)
  Make the update alert API key API work when AAD is out of sync (elastic#56640)
  fix(NA): MaxListenersExceededWarning on getLoggerStream (elastic#57133)
  [Metrics UI] Setup commonly used time ranges in timepicker (elastic#56701)
  [Maps] set filter.meta.key to geoFieldName so query passes filterMatchesIndex when ignoreFilterIfFieldNotInIndex is true (elastic#56692)
  Create plugin mock for event log plugin (elastic#57048)
  fix ts error on master (elastic#57236)
  Don't create API key for disabled alerts when calling create API (elastic#57041)
  Fix enable and disable API to still work when AAD is out of sync (elastic#56634)
  [DOCS] Canvas embed objects (elastic#57156)
  Delete autocomplete namespace (elastic#57187)
  Security - Inject logout url (elastic#57201)
  ...
@lizozom lizozom mentioned this pull request Feb 12, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppisljar ppisljar ppisljar approved these changes

@weltenwort weltenwort weltenwort approved these changes

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees

@lizozom lizozom

Labels
Feature:New Platform release_note:skip Skip the PR/issue when compiling release notes review v7.7.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@lizozom @elasticmachine @kibanamachine @dgieselaar @weltenwort @ppisljar