Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Fixed logs timezone #57611

Merged
merged 9 commits into from
Feb 14, 2020
Merged

Conversation

igoristic
Copy link
Contributor

Resolves #56903

We were explicitly setting the time zone to either utc or browser now it respects the dateFormat:tz setting

@igoristic igoristic added release_note:enhancement enhancement New value added to drive a business result Team:Monitoring Stack Monitoring team v8.0.0 v7.7.0 v7.6.1 labels Feb 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@igoristic igoristic changed the title Fixed logs timezone [Monitoring] Fixed logs timezone Feb 13, 2020
@igoristic igoristic removed the v7.6.1 label Feb 13, 2020
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Works well, nice job!

@igoristic
Copy link
Contributor Author

@elasticmachine merge upstream

@igoristic
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/visualize/feature_controls/visualize_spaces·ts.Visualize visualize space with no features disabled can view existing Visualization

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/45244

[00:00:00]       │
[00:40:34]         └-: Visualize
[00:40:34]           └-> "before all" hook
[00:40:34]           └-: visualize
[00:40:34]             └-> "before all" hook
[00:40:34]             └-> "before all" hook
[00:40:34]               │ info [logstash_functional] Loading "mappings.json"
[00:40:34]               │ info [logstash_functional] Loading "data.json.gz"
[00:40:34]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.22"
[00:40:34]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.20"
[00:40:34]               │ info [logstash_functional] Skipped restore for existing index "logstash-2015.09.21"
[00:40:36]             └-: space with no features disabled
[00:40:36]               └-> "before all" hook
[00:40:36]               └-> "before all" hook
[00:40:36]                 │ info [visualize/default] Loading "mappings.json"
[00:40:36]                 │ info [visualize/default] Loading "data.json"
[00:40:36]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2/RetFMnb5TnO5BwnarWL2AQ] deleting index
[00:40:36]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_1/TlMfiZ75T5e4ot-gOaUgOQ] deleting index
[00:40:36]                 │ info [visualize/default] Deleted existing index [".kibana_2",".kibana_1"]
[00:40:36]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana] creating index, cause [api], templates [], shards [1]/[0], mappings [_doc]
[00:40:36]                 │ info [visualize/default] Created index ".kibana"
[00:40:36]                 │ debg [visualize/default] ".kibana" settings {"index":{"number_of_shards":"1","auto_expand_replicas":"0-1","number_of_replicas":"0"}}
[00:40:37]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [metricbeat-7] creating index, cause [auto(bulk api)], templates [], shards [1]/[1], mappings []
[00:40:37]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [metricbeat-7/RiGz91FqQmyiC2vT3b8UZQ] create_mapping
[00:40:37]                 │ info [visualize/default] Indexed 8 docs into ".kibana"
[00:40:37]                 │ info [visualize/default] Indexed 1 docs into "metricbeat-7"
[00:40:38]                 │ info Creating index .kibana_2.
[00:40:38]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:40:38]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] updating number_of_replicas to [0] for indices [.kibana_2]
[00:40:38]                 │ info Reindexing .kibana to .kibana_1
[00:40:38]                 │ info [o.e.c.m.MetaDataCreateIndexService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_1] creating index, cause [api], templates [], shards [1]/[1], mappings [_doc]
[00:40:38]                 │ info [o.e.c.r.a.AllocationService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] updating number_of_replicas to [0] for indices [.kibana_1]
[00:40:38]                 │ info [o.e.t.LoggingTaskListener] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] 46124 finished with response BulkByScrollResponse[took=174.5ms,timed_out=false,sliceId=null,updated=0,created=8,deleted=0,batches=1,versionConflicts=0,noops=0,retries=0,throttledUntil=0s,bulk_failures=[],search_failures=[]]
[00:40:38]                 │ info [o.e.c.m.MetaDataDeleteIndexService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana/OiZ2EMcuSwyOKMP8PYZjfA] deleting index
[00:40:39]                 │ info Migrating .kibana_1 saved objects to .kibana_2
[00:40:39]                 │ debg Migrating saved objects space:default, index-pattern:metricbeat-*, custom-space:index-pattern:metricbeat-*, index-pattern:logstash-*, custom_space:index-pattern:logstash-*, visualization:i-exist, custom_space:visualization:i-exist, query:okjpgs
[00:40:39]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2/sTeExORkRSqhYm94YzepMw] update_mapping [_doc]
[00:40:39]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2/sTeExORkRSqhYm94YzepMw] update_mapping [_doc]
[00:40:39]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2/sTeExORkRSqhYm94YzepMw] update_mapping [_doc]
[00:40:39]                 │ info Pointing alias .kibana to .kibana_2.
[00:40:39]                 │ info Finished in 1122ms.
[00:40:39]                 │ debg applying update to kibana config: {"accessibility:disableAnimations":true,"dateFormat:tz":"UTC"}
[00:40:40]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2/sTeExORkRSqhYm94YzepMw] update_mapping [_doc]
[00:40:41]                 │ debg creating space
[00:40:42]                 │ debg created space
[00:40:42]               └-> shows visualize navlink
[00:40:42]                 └-> "before each" hook: global before each
[00:40:42]                 │ debg navigating to home url: http://localhost:6141/s/custom_space/app/kibana#/home
[00:40:42]                 │ debg Navigate to: http://localhost:6141/s/custom_space/app/kibana#/home
[00:40:43]                 │ debg ... sleep(700) start
[00:40:43]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/app/kibana?_t=1581672728942#/home 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:40:43]                 │
[00:40:43]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:40:44]                 │ debg ... sleep(700) end
[00:40:44]                 │ debg returned from get, calling refresh
[00:40:45]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/app/kibana?_t=1581672728942#/home 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:40:45]                 │
[00:40:45]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:40:45]                 │ debg currentUrl = http://localhost:6141/s/custom_space/app/kibana#/home
[00:40:45]                 │          appUrl = http://localhost:6141/s/custom_space/app/kibana#/home
[00:40:45]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:40:53]                 │ debg TestSubjects.find(kibanaChrome)
[00:40:53]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:40:53]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-14T09:32:17Z
[00:40:53]                 │        Adding connection to http://localhost:6141/s/custom_space/elasticsearch
[00:40:53]                 │
[00:40:53]                 │      "
[00:40:53]                 │ debg ... sleep(501) start
[00:40:54]                 │ debg ... sleep(501) end
[00:40:54]                 │ debg in navigateTo url = http://localhost:6141/s/custom_space/app/kibana#/home
[00:40:54]                 │ debg TestSubjects.exists(statusPageContainer)
[00:40:54]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:40:56]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:40:57]                 │ debg navigating to settings url: http://localhost:6141/app/kibana#/management
[00:40:57]                 │ debg Navigate to: http://localhost:6141/app/kibana#/management
[00:40:57]                 │ debg ... sleep(700) start
[00:40:57]                 │ debg browser[INFO] http://localhost:6141/app/kibana?_t=1581672743522#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:40:57]                 │
[00:40:57]                 │ debg browser[INFO] http://localhost:6141/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:40:57]                 │ debg ... sleep(700) end
[00:40:57]                 │ debg returned from get, calling refresh
[00:40:58]                 │ debg browser[INFO] http://localhost:6141/app/kibana?_t=1581672743522#/management 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:40:58]                 │
[00:40:58]                 │ debg browser[INFO] http://localhost:6141/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:40:58]                 │ debg currentUrl = http://localhost:6141/app/kibana#/management
[00:40:58]                 │          appUrl = http://localhost:6141/app/kibana#/management
[00:40:58]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=60000
[00:41:03]                 │ debg TestSubjects.find(kibanaChrome)
[00:41:03]                 │ debg Find.findByCssSelector('[data-test-subj="kibanaChrome"]') with timeout=10000
[00:41:03]                 │ debg browser[INFO] http://localhost:6141/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-14T09:32:28Z
[00:41:03]                 │        Adding connection to http://localhost:6141/elasticsearch
[00:41:03]                 │
[00:41:03]                 │      "
[00:41:03]                 │ debg ... sleep(501) start
[00:41:04]                 │ debg ... sleep(501) end
[00:41:04]                 │ debg in navigateTo url = http://localhost:6141/app/kibana#/management?_g=()
[00:41:04]                 │ debg TestSubjects.exists(statusPageContainer)
[00:41:04]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="statusPageContainer"]') with timeout=2500
[00:41:06]                 │ debg --- retry.tryForTime error: [data-test-subj="statusPageContainer"] is not displayed
[00:41:07]                 │ debg TestSubjects.click(settings)
[00:41:07]                 │ debg Find.clickByCssSelector('[data-test-subj="settings"]') with timeout=10000
[00:41:07]                 │ debg Find.findByCssSelector('[data-test-subj="settings"]') with timeout=10000
[00:41:09]                 │ debg isGlobalLoadingIndicatorVisible
[00:41:09]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:41:09]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:41:11]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:41:12]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:41:12]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:41:12]                 │ debg TestSubjects.exists(managementSettingsTitle)
[00:41:12]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="managementSettingsTitle"]') with timeout=120000
[00:41:12]                 │ debg Find.clickByCssSelector('[data-test-subj="advancedSetting-editField-pageNavigation"] option[value="individual"]') with timeout=10000
[00:41:12]                 │ debg Find.findByCssSelector('[data-test-subj="advancedSetting-editField-pageNavigation"] option[value="individual"]') with timeout=10000
[00:41:12]                 │ debg isGlobalLoadingIndicatorVisible
[00:41:12]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:41:12]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:41:14]                 │ debg --- retry.tryForTime error: [data-test-subj="globalLoadingIndicator"] is not displayed
[00:41:14]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:41:14]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:41:14]                 │ debg TestSubjects.click(advancedSetting-saveEditField-pageNavigation)
[00:41:14]                 │ debg Find.clickByCssSelector('[data-test-subj="advancedSetting-saveEditField-pageNavigation"]') with timeout=10000
[00:41:14]                 │ debg Find.findByCssSelector('[data-test-subj="advancedSetting-saveEditField-pageNavigation"]') with timeout=10000
[00:41:15]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2/sTeExORkRSqhYm94YzepMw] update_mapping [_doc]
[00:41:15]                 │ debg isGlobalLoadingIndicatorVisible
[00:41:15]                 │ debg TestSubjects.exists(globalLoadingIndicator)
[00:41:15]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="globalLoadingIndicator"]') with timeout=1500
[00:41:15]                 │ debg TestSubjects.exists(globalLoadingIndicator-hidden)
[00:41:15]                 │ debg Find.existsByCssSelector('[data-test-subj="globalLoadingIndicator-hidden"]') with timeout=100000
[00:41:15]                 │ debg TestSubjects.find(navDrawer)
[00:41:15]                 │ debg Find.findByCssSelector('[data-test-subj="navDrawer"]') with timeout=10000
[00:41:15]                 └- ✓ pass  (33.2s) "Visualize visualize space with no features disabled shows visualize navlink"
[00:41:15]               └-> can view existing Visualization
[00:41:15]                 └-> "before each" hook: global before each
[00:41:15]                 │ debg navigateToActualUrl http://localhost:6141/s/custom_space/app/kibana#/visualize/edit/i-exist
[00:41:15]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/app/kibana?_t=1581672762123#/visualize/edit/i-exist 350 Refused to execute inline script because it violates the following Content Security Policy directive: "script-src 'unsafe-eval' 'self'". Either the 'unsafe-inline' keyword, a hash ('sha256-P5polb1UreUSOe5V/Pv7tc+yeZuJXiOi/3fqhGsU7BE='), or a nonce ('nonce-...') is required to enable inline execution.
[00:41:15]                 │
[00:41:15]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/app/kibana/bootstrap.js 9:19 "^ A single error about an inline script not firing due to content security policy is expected!"
[00:41:15]                 │ debg TestSubjects.exists(visualizationLoader)
[00:41:15]                 │ debg Find.existsByDisplayedByCssSelector('[data-test-subj="visualizationLoader"]') with timeout=10000
[00:41:20]                 │ debg --- retry.tryForTime error: [data-test-subj="visualizationLoader"] is not displayed
[00:41:25]                 │ info [o.e.c.m.MetaDataMappingService] [kibana-ci-immutable-centos-tests-xl-1581667915106324877] [.kibana_2/sTeExORkRSqhYm94YzepMw] update_mapping [_doc]
[00:41:25]                 │ debg browser[INFO] http://localhost:6141/s/custom_space/bundles/plugin/data/data.plugin.js 67:139970 "INFO: 2020-02-14T09:32:49Z
[00:41:25]                 │        Adding connection to http://localhost:6141/s/custom_space/elasticsearch
[00:41:25]                 │
[00:41:25]                 │      "
[00:41:25]                 │ debg --- retry.tryForTime failed again with the same message...
[00:41:26]                 │ info Taking screenshot "/dev/shm/workspace/kibana/x-pack/test/functional/screenshots/failure/Visualize visualize space with no features disabled can view existing Visualization.png"
[00:41:26]                 │ info Current URL is: http://localhost:6141/s/custom_space/app/kibana#/visualize/edit/i-exist?_g=(refreshInterval:(pause:!t,value:0),time:(from:now-15m,to:now))&_a=(filters:!(),linked:!f,query:(language:lucene,query:%27%27),uiState:(),vis:(aggs:!((enabled:!t,id:%271%27,params:(),schema:metric,type:count),(enabled:!t,id:%272%27,params:(field:geo.src,missingBucket:!f,missingBucketLabel:Missing,order:desc,orderBy:%271%27,otherBucket:!f,otherBucketLabel:Other,size:5),schema:segment,type:terms)),params:(addLegend:!t,addTooltip:!t,dimensions:(metric:(accessor:0,aggType:count,format:(id:number),params:())),isDonut:!t,labels:(last_level:!t,show:!f,truncate:100,values:!t),legendPosition:right,type:pie),title:%27A%20Pie%27,type:pie))
[00:41:27]                 │ info Saving page source to: /dev/shm/workspace/kibana/x-pack/test/functional/failure_debug/html/Visualize visualize space with no features disabled can view existing Visualization.html
[00:41:27]                 └- ✖ fail: "Visualize visualize space with no features disabled can view existing Visualization"
[00:41:27]                 │

Stack Trace

Error: expected testSubject(visualizationLoader) to exist
    at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:60:15)

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@igoristic igoristic merged commit f8b06e3 into elastic:master Feb 14, 2020
@igoristic igoristic deleted the issue-56903 branch February 14, 2020 11:29
@igoristic
Copy link
Contributor Author

Backport:
7.x: 3bc0dfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backported enhancement New value added to drive a business result release_note:enhancement Team:Monitoring Stack Monitoring team v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Monitoring] Elasticsearch logs timestamp do not respect the client timezone
4 participants