Filebeat wizard #5790
Filebeat wizard #5790
Conversation
(cherry picked from commit 8cbf211)
(cherry picked from commit 1fc754b)
(cherry picked from commit 4975f57)
(cherry picked from commit 599e012)
(cherry picked from commit 36dc443)
(cherry picked from commit ad25d24)
(cherry picked from commit 4bcc5a1)
| var template = require('plugins/kibana/settings/sections/data/directives/install_filebeat_step.html'); | ||
|
|
||
| modules.get('apps/settings') | ||
| .directive('installFilebeatStep', function () { |
There was a problem hiding this comment.
Who needs eslint when I've got spalinter?
|
Clicking 'don't show this alert again' the previous button/window.back doesn't work |
|
Would it be possible to make the alert only show up if there are changes? |
| <a href="#/settings/indices/create/filebeat">Tail a File</a> | ||
| </h4> | ||
| <div> | ||
| Pick this option if you have log data you'd like to send to Elasticsearch. |
There was a problem hiding this comment.
thoughts on this saying log files or log file data?
There was a problem hiding this comment.
Log file data sounds ok to me. I wouldn't worry too much about the descriptive text, I'm guessing some wordsmith will refine these later on.
|
@jbudz You said "Clicking 'don't show this alert again' the previous button/window.back doesn't work". What browser are you using that gives you that option? I don't see that anywhere in Firefox, Safari, or Chrome. |
|
Chrome 48. The first time the message shows up it won't be there, but cancelling once will cause it to show |
|
Ah interesting.... do you know how we've handled this in other areas of the code that use this safe confirm utility? |
|
I tested overwriting an index pattern, it causes the button to do nothing. |
|
LGTM, assuming build failures are simply caused by not being merged with master |
Creates the shell for the tail a file wizard described in #5974
Requires #5956 which has been merged into this branch, so reviewers can ignore the files that were changed in that PR as they're being reviewed separately.
This PR only addresses the functionality of the wizard container, not the individual steps. It demonstrates how data will flow from step to step with placeholder directives for each step, and it provides the logic necessary for controlling the user's navigation (preventing the user from jumping to a step they're not ready for, warning them if they're going to navigate back and lose changes, and using app state to make the back-forward buttons work).
Styling will be addressed in a future PR once the design is finalized.
Original comment
@BigFunger I started working on the wizard that the individual ingest steps we're working on will live in. I wanted to get it up in a PR so you could see what direction I'm headed in and let me know what you think. Conceptually I'm thinking the individual steps (pipeline building, index pattern creation, etc) will be reusable directives that each optionally take some input and when they're finished, return some output to the wizard controller. The directives themselves shouldn't know or care that they're a part of a larger multi-step wizard, they just take some input and return some results while the wizard maintains state and ordering of the steps. That way each step can be reused across different wizards (filebeat, topbeat, csv, etc).
The wizard controller itself can probably be more general than what I have here, or even moved inside a directive, but I haven't quite figured that out yet.