Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Avoid accessing a non-existing index when bucket is empty #58481

Merged
merged 2 commits into from
Feb 25, 2020
Merged

[APM] Avoid accessing a non-existing index when bucket is empty #58481

merged 2 commits into from
Feb 25, 2020

Conversation

sorenlouv
Copy link
Member

@sorenlouv sorenlouv commented Feb 25, 2020 •
edited
Loading

On the JVM Metrics page the following error would occur under certain conditions:

TypeError: Cannot read property 'key' of undefined
    at getServiceNodeMetadata (/usr/share/kibana/x-pack/legacy/plugins/apm/server/lib/services/get_service_node_metadata.js:57:171)
    at process._tickCallback (internal/process/next_tick.js:68:7)

This is caused by accessing an invalid index of an array.

Originally fixed in: #57767

@sorenlouv sorenlouv added release_note:fix v7.6.1 Team:APM All issues that need APM UI Team support labels Feb 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@sorenlouv sorenlouv merged commit b36a553 into 7.6 Feb 25, 2020
@sorenlouv sorenlouv deleted the avoid-invalid-index-on-empty-bucket branch February 25, 2020 16:20
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgieselaar dgieselaar dgieselaar approved these changes

Assignees
No one assigned
Labels
release_note:fix Team:APM All issues that need APM UI Team support v7.6.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sorenlouv @elasticmachine @kibanamachine @dgieselaar