-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fixing licensing after server NP cutover #58853
[ML] Fixing licensing after server NP cutover #58853
Conversation
b58b144
to
cd797b8
Compare
Pinging @elastic/ml-ui (:ml) |
retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good overall, just added some question regarding licensing for data visualizer.
756a443
to
4687504
Compare
retest |
4687504
to
e9fdc8c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested with a range of licenses and security settings and LGTM.
@elasticmachine merge upstream |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest edits LGTM ⚡️
* [ML] Fixing licensing after server NP cutover * client side refactor * management refactor * moving management license check * adding server side license class * added common license class * client sides using license class * updating server api guards * fix privileges tests * updating translations * fixing disabled tabs on basic license * refactoring client side license checks * setting license initialized flag * fixing license check on index data viz Co-authored-by: Elastic Machine <[email protected]>
This reverts commit fd5c6c1.
💔 Build FailedTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/lens_reporting·ts.lens app lens reporting should not cause PDF reports to failStandard Out
Stack Trace
Kibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/lens_reporting·ts.lens app lens reporting should not cause PDF reports to failStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
THIS WAS REVERTED.
The PR you're looking for is #59275
Reenables the license checking for server and client sides after server side cutover (#58680)
A shared common
mlLicense
class has been added which listens to the licensing updates from the licensing plugin.The server and client then have specialised derived classes which add on checks specific to their needs
Server side
Basic enabled endpoints:
/api/ml/fields_service/time_field_range
/api/ml/file_data_visualizer/analyze_file
/api/ml/file_data_visualizer/import
/api/ml/_has_privileges
/api/ml/ml_capabilities
/api/ml/ml_node_count
/api/ml/info
/api/ml/data_visualizer/get_field_stats/{indexPatternTitle}
/api/ml/data_visualizer/get_overall_stats/{indexPatternTitle}
Client side:
hasLicenseExpired
andisFullLicense
general functions which are used in a few places throughout our UI.Also fixes the management plugin which was being disabled due to its licensing check.
Checklist
Delete any items that are not applicable to this PR.
For maintainers