Have to click save after resetting advanced setting to default #59216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeeDr
added
test_ui_functional
v8.0.0
release_note:skip
|
Pinging @elastic/kibana-platform (Team:Platform) |
|
@elasticmachine merge upstream |
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
|
NOTE: Someone pointed out the change PR (linked in the Summary section). So I know this PR needs to go into 7.7 as well. |
LeeDr
pushed a commit
that referenced
this pull request
Mar 4, 2020
… (#59339) Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A UI change at some point changed the behavior of resetting an advanced setting. In older versions like 7.5, if you clicked
Reset to defaulton an advanced setting it instantly saved it (or maybe it clears the setting from the config?). But on master, you now have to click Save.This test
test/functional/apps/visualize/_lab_mode.jshas an after method which callsPageObjects.settings.clearAdvancedSettings('visualize:enableLabs');. But since that settings_page method wasn't clicking the Save button it really wasn't resetting it to the default.This would cause the vega tests to fail if they are run all together like locally running all the visualize tests. This isn't causing failures on Jenkins only because the lab_mode test is in one ciGroup and the vega test is in another ciGroup, so it starts with the default settings.
Checklist
Delete any items that are not applicable to this PR.