[APM] Service maps fix for service name/env filtering & centering #59726
Conversation
ogupte
added
release_note:skip
| : undefined | ||
| } | ||
| > | ||
| <EuiButton color="secondary" href={focusUrl} onClick={onFocusClick}> |
There was a problem hiding this comment.
Why doesn't this get disabled any more? Now clicking it just does nothing.
There was a problem hiding this comment.
Er, I guess it centers the map on that element but that kind of changes the meaning of what "focus" is.
There was a problem hiding this comment.
The expectation of user flow is: click focus button -> navigate to and render map centered on a selected node. With this update, it flow is the same, except it skips the loading/navigation since it's already loaded. No matter when I click that button, the end state should be the same. At least that's what i felt after playing with it for a while. Having the button disabled felt more jarring.
| @@ -85,6 +85,14 @@ export function Popover({ focusedServiceName }: PopoverProps) { | |||
| } | |||
| }, [popoverRef, x, y]); | |||
|
|
|||
| const centerSelectedNode = useCallback(() => { | |||
| if (cy) { | |||
| cy.center(cy.getElementById(selectedNodeServiceName)); | |||
There was a problem hiding this comment.
Instead of center, we should animate it with cy.animate({ center: { eles: cy.getElementById(selectedNodeServiceName) } })
There was a problem hiding this comment.
Right now animations are being initiated between data load, so it gets a little jumpy. we'll have to fix it in another PR, but this makes sense to animate right now.
|
@elasticmachine merge upstream |
…ervice - fixes z-indexing issues with overlapping edges when hovering on a service node - always centers on the focused service node after layout reflows
…ocused service navigation - fix layout bug by passing undefined for roots (instead of []) in service maps layout when no roots are found
This reverts commit d482aa124b1f2c47da01d4386c2b88108bc94275.
ogupte
force-pushed
the
apm-59720-fix-filtering-centering
branch
from
5aa411f to
33ed314
Compare
…astic#59726) * - adds primary color highlighting to connected edges of the focused service - fixes z-indexing issues with overlapping edges when hovering on a service node - always centers on the focused service node after layout reflows * re-centers the already focused service node when the focus button is clicked * remove environemnt filter when querying for sample trace ids * - fixes missing query params in the generated hrefs for details and focused service navigation - fix layout bug by passing undefined for roots (instead of []) in service maps layout when no roots are found * Revert "remove environemnt filter when querying for sample trace ids" This reverts commit d482aa124b1f2c47da01d4386c2b88108bc94275. * Fixes extra prop from a merge conflict
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…9726) (#60129) * - adds primary color highlighting to connected edges of the focused service - fixes z-indexing issues with overlapping edges when hovering on a service node - always centers on the focused service node after layout reflows * re-centers the already focused service node when the focus button is clicked * remove environemnt filter when querying for sample trace ids * - fixes missing query params in the generated hrefs for details and focused service navigation - fix layout bug by passing undefined for roots (instead of []) in service maps layout when no roots are found * Revert "remove environemnt filter when querying for sample trace ids" This reverts commit d482aa124b1f2c47da01d4386c2b88108bc94275. * Fixes extra prop from a merge conflict
Closes #59720, #59168, #59747.