[plugins] re-enable publicDir option, but require that it is "public" #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We some tests around plugins... EDIT: Gave this a run, looks good. I want to test with an actual package though, that's the hold up right now. This should be GTG though. |
|
Works a treat, thanks for the fix! |
w33ble
added a commit
that referenced
this pull request
Feb 1, 2016
[plugins] re-enable publicDir option, but require that it is "public"
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In spalger@402dfe9 I removed the ability for plugins to specify their "publicDir" because we needed a predicatble way to find files destined for the front-end.
This prevented us from allowing multiple plugins to be nested inside another plugin, which we knew we would need.
This re-enabled the
plugin.publicDir, but requires that it end in a directory called "public". This way, we can still do generic"**/public/**/*.js"type selectors, and plugins can be nested.