Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest Node Pipelines UI #62321

Merged
merged 33 commits into from
Apr 30, 2020
Merged
Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
c19382d
initial plugin setup
alisonelizabeth Apr 3, 2020
bf94f1c
add smoke test
alisonelizabeth Apr 5, 2020
e24165e
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth Apr 5, 2020
b0bb193
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth Apr 6, 2020
5a536bd
fix license check
alisonelizabeth Apr 6, 2020
ef2f1ab
refactor plugin setup
alisonelizabeth Apr 6, 2020
fc9235b
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine Apr 7, 2020
a841441
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine Apr 7, 2020
7de73c8
Server-side create/update ingest pipelines (#62744)
alisonelizabeth Apr 8, 2020
ac0ac2b
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine Apr 8, 2020
699ebef
List pipelines (#62785)
jloleysens Apr 9, 2020
92b3f21
[Ingest pipelines] Create pipeline UI (#63017)
alisonelizabeth Apr 14, 2020
993d065
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth Apr 14, 2020
cf8b36b
[Ingest pipelines] Edit pipeline page (#63522)
alisonelizabeth Apr 15, 2020
8d18877
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth Apr 20, 2020
7e7d776
[Ingest pipelines] Polish details panel and empty list (#63926)
alisonelizabeth Apr 20, 2020
6ffaeda
[Ingest pipelines] Delete pipeline (#63635)
alisonelizabeth Apr 20, 2020
2c340b2
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
jloleysens Apr 21, 2020
34cb91a
[Ingest Node Pipelines] Clone Pipeline (#64049)
jloleysens Apr 22, 2020
eba5305
[Ingest node pipelines] Privileges (#63850)
jloleysens Apr 23, 2020
dbc5cc5
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine Apr 24, 2020
a2b4049
[Ingest Node Pipelines] More lenient treatment of on-failure value (#…
jloleysens Apr 25, 2020
cad13fd
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine Apr 27, 2020
fc0ed64
[Ingest pipelines] Simulate pipeline (#64223)
alisonelizabeth Apr 27, 2020
6dbdf06
[Ingest Node Pipelines] Show flyout after editing or creating a pipel…
jloleysens Apr 28, 2020
a9c5384
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth Apr 29, 2020
5643419
fix TS
alisonelizabeth Apr 29, 2020
f3a16f2
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine Apr 29, 2020
7010b9e
Merge branch 'master' of github.com:elastic/kibana into feature/inges…
alisonelizabeth Apr 29, 2020
3c4353f
Merge branch 'master' into feature/ingest-node-pipelines
elasticmachine Apr 30, 2020
a4c298d
[Ingest pipelines] Cleanup (#64794)
alisonelizabeth Apr 30, 2020
5bbb9fc
address review feedback
alisonelizabeth Apr 30, 2020
dd93b11
remove unused import
alisonelizabeth Apr 30, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[Ingest pipelines] Polish details panel and empty list (#63926)
alisonelizabeth authored Apr 20, 2020

Unverified

No user is associated with the committer email.
commit 7e7d7765a29de40a46a08e4d9cbdf887716c849c
Original file line number Diff line number Diff line change
@@ -12,7 +12,8 @@ import {
EuiFlyoutBody,
EuiTitle,
EuiDescriptionList,
EuiSpacer,
EuiDescriptionListTitle,
EuiDescriptionListDescription,
EuiFlyoutFooter,
EuiFlexGroup,
EuiFlexItem,
@@ -35,24 +36,6 @@ export const PipelineDetails: FunctionComponent<Props> = ({
onEditClick,
onDeleteClick,
}) => {
const descriptionListItems = [
{
title: i18n.translate('xpack.ingestPipelines.list.pipelineDetails.descriptionTitle', {
defaultMessage: 'Description',
}),
description: pipeline.description ?? '',
},
];

if (pipeline.version) {
descriptionListItems.push({
title: i18n.translate('xpack.ingestPipelines.list.pipelineDetails.versionTitle', {
defaultMessage: 'Version',
}),
description: String(pipeline.version),
});
}

return (
<EuiFlyout
onClose={onClose}
@@ -67,35 +50,58 @@ export const PipelineDetails: FunctionComponent<Props> = ({
</EuiFlyoutHeader>

<EuiFlyoutBody>
<EuiDescriptionList listItems={descriptionListItems} />
<EuiDescriptionList>
{/* Pipeline description */}
<EuiDescriptionListTitle>
{i18n.translate('xpack.ingestPipelines.list.pipelineDetails.descriptionTitle', {
defaultMessage: 'Description',
})}
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
{pipeline.description ?? ''}
</EuiDescriptionListDescription>

<EuiSpacer size="m" />
{/* Pipeline version */}
{pipeline.version && (
<>
<EuiDescriptionListTitle>
{i18n.translate('xpack.ingestPipelines.list.pipelineDetails.versionTitle', {
defaultMessage: 'Version',
})}
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
{String(pipeline.version)}
</EuiDescriptionListDescription>
</>
)}

<PipelineDetailsJsonBlock
htmlForId="pipelineDetailsProcessorsJson"
label={i18n.translate('xpack.ingestPipelines.list.pipelineDetails.processorsTitle', {
defaultMessage: 'Processors JSON',
})}
json={pipeline.processors}
/>
{/* Processors JSON */}
<EuiDescriptionListTitle>
{i18n.translate('xpack.ingestPipelines.list.pipelineDetails.processorsTitle', {
defaultMessage: 'Processors JSON',
})}
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<PipelineDetailsJsonBlock json={pipeline.processors} />
</EuiDescriptionListDescription>

{/* On Failure Processor JSON */}
{pipeline.on_failure?.length && (
<>
<EuiSpacer size="m" />
<PipelineDetailsJsonBlock
htmlForId="pipelineDetailsOnFailureProcessorsJson"
label={i18n.translate(
'xpack.ingestPipelines.list.pipelineDetails.failureProcessorsTitle',
{
defaultMessage: 'On failure processors JSON',
}
)}
json={pipeline.on_failure}
/>
</>
)}
{/* End On Failure Processor JSON */}
{/* On Failure Processor JSON */}
{pipeline.on_failure?.length && (
<>
<EuiDescriptionListTitle>
{i18n.translate(
'xpack.ingestPipelines.list.pipelineDetails.failureProcessorsTitle',
{
defaultMessage: 'On failure processors JSON',
}
)}
</EuiDescriptionListTitle>
<EuiDescriptionListDescription>
<PipelineDetailsJsonBlock json={pipeline.on_failure} />
</EuiDescriptionListDescription>
</>
)}
</EuiDescriptionList>
</EuiFlyoutBody>

<EuiFlyoutFooter>
Original file line number Diff line number Diff line change
@@ -4,24 +4,28 @@
* you may not use this file except in compliance with the Elastic License.
*/

import React, { FunctionComponent } from 'react';
import { EuiCodeBlock, EuiText } from '@elastic/eui';
import React, { FunctionComponent, useRef } from 'react';
import { EuiCodeBlock } from '@elastic/eui';

export interface Props {
htmlForId: string;
label: string;
json: Record<string, any>;
}

export const PipelineDetailsJsonBlock: FunctionComponent<Props> = ({ label, htmlForId, json }) => (
<>
<EuiText size="s">
<label htmlFor={htmlForId}>
<b>{label}</b>
</label>
</EuiText>
<EuiCodeBlock paddingSize="s" id={htmlForId} language="json" overflowHeight={200} isCopyable>
export const PipelineDetailsJsonBlock: FunctionComponent<Props> = ({ json }) => {
// Hack so copied-to-clipboard value updates as content changes
// Related issue: https://github.com/elastic/eui/issues/3321
const uuid = useRef(0);
uuid.current++;

return (
<EuiCodeBlock
paddingSize="s"
language="json"
overflowHeight={json.length > 0 ? 300 : undefined}
isCopyable
key={uuid.current}
>
{JSON.stringify(json, null, 2)}
</EuiCodeBlock>
</>
);
);
};
Original file line number Diff line number Diff line change
@@ -14,12 +14,12 @@ export const EmptyList: FunctionComponent = () => (
title={
<h2>
{i18n.translate('xpack.ingestPipelines.list.table.emptyPromptTitle', {
defaultMessage: 'Create your first pipeline',
defaultMessage: 'Start by creating a pipeline',
})}
</h2>
}
actions={
<EuiButton href={`#${BASE_PATH}/create`}>
<EuiButton href={`#${BASE_PATH}/create`} iconType="plusInCircle" fill>
{i18n.translate('xpack.ingestPipelines.list.table.emptyPrompt.createButtonLabel', {
defaultMessage: 'Create a pipeline',
})}