Allow markdown in error embeddable #62427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
reviewed
Apr 3, 2020
| ReactDOM.render( | ||
| // @ts-ignore | ||
| <div className="embPanel__error embPanel__content" data-test-subj="embeddableStackError"> | ||
| <EuiText color="subdued" size="xs"> | ||
| <EuiIcon type="alert" color="danger" /> | ||
| <EuiSpacer size="s" /> | ||
| {title} | ||
| <div /* eslint-disable-next-line react/no-danger */ |
There was a problem hiding this comment.
I haven't pulled this PR down yet, but it seems like the Markdown component is already doing exactly this: https://github.com/elastic/kibana/blob/master/src/plugins/kibana_react/public/markdown/markdown.tsx
Is there anything blocking us from using it here?
There was a problem hiding this comment.
I thought it was an overkill, since the message may not even be a markdown. But on second thought, it makes sense.
|
@elasticmachine merge upstream |
flash1293
approved these changes
Apr 6, 2020
| import { EmbeddableRoot } from './embeddable_root'; | ||
| import { mount } from 'enzyme'; | ||
| // @ts-ignore | ||
| import { findTestSubject } from '@elastic/eui/lib/test'; |
There was a problem hiding this comment.
findTestSubject is unused.
There was a problem hiding this comment.
Will fix this in the next PR, would like to get this in for 7.7
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Apr 6, 2020
majagrubic
pushed a commit
to majagrubic/kibana
that referenced
this pull request
Apr 6, 2020
* Allow markdown in error embeddable * Replace markdown factory with markdown component Co-authored-by: Elastic Machine <[email protected]>
majagrubic
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Allow markdown in error embeddable * Replace markdown factory with markdown component Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
majagrubic
pushed a commit
that referenced
this pull request
Apr 6, 2020
* Allow markdown in error embeddable * Replace markdown factory with markdown component Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
This was referenced May 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: #61590
Now we render markdown in an error embeddable.
Checklist
Delete any items that are not applicable to this PR.
- [] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibility- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browserFor maintainers