Tighten up spacing, move drag handle, move spy toggle

package.json

@@ -57,7 +57,8 @@
     "lint": "grunt eslint:source",
     "lintroller": "grunt eslint:fixSource",
     "mocha": "mocha",
-    "mocha:debug": "mocha --debug-brk"
+    "mocha:debug": "mocha --debug-brk",
+    "sterilize": "grunt sterilize"
   },
   "repository": {
     "type": "git",
@@ -100,6 +101,7 @@
     "extract-text-webpack-plugin": "0.8.2",
     "file-loader": "0.8.4",
     "font-awesome": "4.4.0",
+    "glob-all": "3.0.1",
     "good": "6.3.0",
     "good-squeeze": "2.1.0",
     "gridster": "0.5.6",
@@ -149,7 +151,6 @@
     "eslint-plugin-mocha": "1.1.0",
     "expect.js": "0.3.1",
     "faker": "1.1.0",
-    "glob": "4.5.3",
     "grunt": "0.4.5",
     "grunt-babel": "5.0.1",
     "grunt-cli": "0.1.13",

src/cli/plugin/__tests__/plugin_downloader.js

@@ -1,7 +1,7 @@
 import expect from 'expect.js';
 import sinon from 'sinon';
 import nock from 'nock';
-import glob from 'glob';
+import glob from 'glob-all';
 import rimraf from 'rimraf';
 import mkdirp from 'mkdirp';
 import pluginLogger from '../plugin_logger';

src/cli/plugin/__tests__/plugin_extractor.js

@@ -1,6 +1,6 @@
 import expect from 'expect.js';
 import sinon from 'sinon';
-import glob from 'glob';
+import glob from 'glob-all';
 import rimraf from 'rimraf';
 import mkdirp from 'mkdirp';
 

src/plugins/kibana/public/dashboard/components/panel/panel.html

@@ -7,6 +7,9 @@
       <a aria-label="Edit" ng-show="chrome.getVisible() && editUrl" ng-href="{{::editUrl}}">
         <i aria-hidden="true" class="fa fa-pencil"></i>
       </a>
+      <a aria-label="Move" ng-show="chrome.getVisible()" class="panel-move">
+        <i aria-hidden="true" class="fa fa-arrows"></i>
+      </a>
       <a aria-label="Remove" ng-show="chrome.getVisible()" ng-click="remove()">
         <i aria-hidden="true" class="fa fa-times"></i>
       </a>

src/plugins/kibana/public/dashboard/directives/grid.js

@@ -27,7 +27,7 @@ app.directive('dashboardGrid', function ($compile, Notifier) {
       // number of columns to render
       const COLS = 12;
       // number of pixed between each column/row
-      const SPACER = 10;
+      const SPACER = 0;
       // pixels used by all of the spacers (gridster puts have a spacer on the ends)
       const spacerSize = SPACER * COLS;
 
@@ -46,7 +46,7 @@ app.directive('dashboardGrid', function ($compile, Notifier) {
             stop: readGridsterChangeHandler
           },
           draggable: {
-            handle: '.panel-heading, .panel-title',
+            handle: '.panel-move, .fa-arrows',
             stop: readGridsterChangeHandler
           }
         }).data('gridster');
@@ -232,4 +232,3 @@ app.directive('dashboardGrid', function ($compile, Notifier) {
     }
   };
 });
-

src/plugins/kibana/public/dashboard/styles/main.less

@@ -43,14 +43,8 @@ dashboard-grid {
         .visualize-show-spy {
           visibility: visible;
         }
-        .panel .panel-heading {
-          background-color: @kibanaGray6;
-          &:hover {
-            cursor: pointer;
-          }
-          .btn-group {
-            display: block !important;
-          }
+        .panel .panel-heading .btn-group {
+          display: block !important;
         }
       }
 
@@ -117,6 +111,10 @@ dashboard-grid {
           }
         }
 
+        .panel-move:hover {
+          cursor: move;
+        }
+
         a {
           color: @dashboard-panel-heading-link-color;
           border: none;

src/plugins/metric_vis/public/metric_vis.less

@@ -16,6 +16,5 @@
 
   .metric-container {
     text-align: center;
-    padding: 1em;
   }
 }

src/plugins/testsBundle/findSourceFiles.js

@@ -3,29 +3,27 @@ import fromRoot from '../../utils/fromRoot';
 import { chain, memoize } from 'lodash';
 import { resolve } from 'path';
 import { map, fromNode } from 'bluebird';
-import { Glob } from 'glob';
+import glob from 'glob-all';
 
 let findSourceFiles = async (patterns, cwd = fromRoot('.')) => {
   patterns = [].concat(patterns || []);
 
-  let matcheses = await map(patterns, async pattern => {
-    return await fromNode(cb => {
-      let g = new Glob(pattern, {
-        cwd: cwd,
-        ignore: [
-          'node_modules/**/*',
-          'bower_components/**/*',
-          '**/_*.js'
-        ],
-        symlinks: findSourceFiles.symlinks,
-        statCache: findSourceFiles.statCache,
-        realpathCache: findSourceFiles.realpathCache,
-        cache: findSourceFiles.cache
-      }, cb);
-    });
+  const matches = await fromNode(cb => {
+    glob(patterns, {
+      cwd: cwd,
+      ignore: [
+        'node_modules/**/*',
+        'bower_components/**/*',
+        '**/_*.js'
+      ],
+      symlinks: findSourceFiles.symlinks,
+      statCache: findSourceFiles.statCache,
+      realpathCache: findSourceFiles.realpathCache,
+      cache: findSourceFiles.cache
+    }, cb);
   });
 
-  return chain(matcheses)
+  return chain(matches)
   .flatten()
   .uniq()
   .map(match => resolve(cwd, match))

src/plugins/testsBundle/index.js

@@ -9,7 +9,8 @@ module.exports = (kibana) => {
     config: (Joi) => {
       return Joi.object({
         enabled: Joi.boolean().default(true),
-        instrument: Joi.boolean().default(false)
+        instrument: Joi.boolean().default(false),
+        pluginId: Joi.string()
       }).default();
     },
 
@@ -18,21 +19,35 @@ module.exports = (kibana) => {
         let modules = [];
         let config = kibana.config;
 
-        // add the modules from all of the apps
-        for (let app of apps) {
-          modules = union(modules, app.getModules());
-        }
+        const testGlobs = ['src/ui/public/**/*.js'];
+        const testingPluginId = config.get('testsBundle.pluginId');
+
+        if (testingPluginId) {
+          const plugin = plugins.byId[testingPluginId];
+          if (!plugin) throw new Error('Invalid testingPluginId :: unknown plugin ' + testingPluginId);
+
+          // add the modules from all of this plugins apps
+          for (let app of plugin.apps) {
+            modules = union(modules, app.getModules());
+          }
 
-        const testGlobs = [
-          'src/ui/public/**/__tests__/**/*.js',
-        ];
+          testGlobs.push(
+            '!src/ui/public/**/__tests__/**/*',
+            `${plugin.publicDir}/**/__tests__/**/*.js`
+          );
+        } else {
 
-        for (const plugin of plugins) {
-          testGlobs.push(`${plugin.publicDir}/**/__tests__/**/*.js`);
+          // add the modules from all of the apps
+          for (let app of apps) {
+            modules = union(modules, app.getModules());
+          }
+
+          for (const plugin of plugins) {
+            testGlobs.push(`${plugin.publicDir}/**/__tests__/**/*.js`);
+          }
         }
 
         const testFiles = await findSourceFiles(testGlobs);
-
         for (let f of testFiles) modules.push(f);
 
         if (config.get('testsBundle.instrument')) {

src/ui/public/visualize/spy.html

@@ -1,6 +1,6 @@
 <div class="visualize-show-spy">
   <div ng-click="toggleDisplay()" class="visualize-show-spy-tab">
-    <i class="fa" ng-class="spy.mode.name ? 'fa-chevron-down' : 'fa-chevron-up'"></i>
+    <i class="fa" ng-class="spy.mode.name ? 'fa-chevron-circle-down' : 'fa-chevron-circle-up'"></i>
   </div>
 </div>
 <div ng-show="spy.mode.name" class="visualize-spy-container">
@@ -21,4 +21,4 @@
       </a>
     </div>
   </header>
-</div>
+</div>

src/ui/public/visualize/visualize.less

@@ -59,6 +59,7 @@ ul.visualizations .media-body {
 visualize-spy {
   // this element should flex
   flex: 0 1 auto;
+  padding: 0px 0px 0px 15px;
 
   // it's children should also flex vertically
   flex-direction: column;
@@ -77,34 +78,12 @@ visualize-spy {
 
   .visualize-show-spy {
     flex: 0 0 auto;
-
-    border-top: 1px solid;
-    border-top-color: @visualize-show-spy-border;
-    margin-bottom: 3px;
-
     &-tab {
-      margin: 0px auto;
-      margin-top: -1px;
-      border: 1px solid;
-      border-color: @visualize-show-spy-border;
-      border-top: 0px;
-      border-width: 0px 1px 1px 1px;
-      border-bottom-left-radius: @border-radius-base;
-      border-bottom-right-radius: @border-radius-base;
-      width: 50px;
-      background: @visualize-show-spy-bg;
-      text-align: center;
-      color: @visualize-show-spy-color;
-
-      &:hover {
-        background-color: @visualize-show-spy-hover-bg;
-        color: @visualize-show-spy-hover-color;
-      }
-    }
-
-
-    i {
-      padding: 0 10px;
+      color: @kibanaGray4;
+      position: absolute;
+      z-index: 100;
+      left: 5px;
+      bottom: 0px;
     }
   }
 
@@ -181,4 +160,3 @@ visualize-spy {
     white-space: pre-wrap;
   }
 }
-

src/ui/ui_app.js

@@ -1,4 +1,5 @@
 import { chain, get, noop, once, pick } from 'lodash';
+import _ from 'lodash';
 
 class UiApp {
   constructor(uiExports, spec) {