[Alerting] fixes to allow pre-configured actions to be executed #63432

pmuellr · 2020-04-14T01:09:04Z

resolves #63162

Most of the support for pre-configured actions has already been added
to Kibana, except for one small piece. The ability for them to be
executed. This PR adds that support.

Checklist

Unit or functional tests were updated or added to match the most common scenarios

elasticmachine · 2020-04-14T01:09:06Z

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

resolves elastic#63162 Most of the support for pre-configured actions has already been added to Kibana, except for one small piece. The ability for them to be executed. This PR adds that support.

pmuellr · 2020-04-14T16:48:35Z

x-pack/plugins/actions/server/create_execute_function.test.ts

@@ -68,6 +69,68 @@ describe('execute()', () => {
    });
  });

+  test('schedules the action with all given parameters with a preconfigured action', async () => {


This is a copy of the test above it, only changing to use a preconfigured action.

pmuellr · 2020-04-14T16:50:27Z

x-pack/plugins/actions/server/create_execute_function.ts

      params: {
        spaceId,
        actionTaskParamsId: actionTaskParamsRecord.id,
      },
      state: {},
      scope: ['actions'],
    });
+
+    async function getActionTypeId(actionId: string): Promise<string> {


As a side note, we might want to look at denormalizing the action type along side action id, where appropriate, to avoid this SO lookup just to get the action type. OTOH, it's only when actions are executed, so ... it's not on every turn of an alert ...

(Moment not writing a comment haunts me): I think the lookup is also there to ensure the user has access to read that action, otherwise it would fail the attempt to create a task executing that action.

Sigh note, this would also mean pre-configured actions don't work with feature controls at this time. I will open a separate issue for that, to test and validate that theory but the implementation below looks good.

Created issue here: #63496.

pmuellr · 2020-04-14T16:51:38Z

x-pack/test/alerting_api_integration/common/config.ts

@@ -100,6 +100,27 @@ export function createTestConfig(name: string, options: CreateTestConfigOptions)
                xyzSecret2: 'credential2',
              },
            },
+            {


More pre-configured actions, used in the tests below. Show up in the various getAll() tests as well ...

pmuellr · 2020-04-14T16:52:45Z

...integration/security_and_spaces/tests/actions/builtin_action_types/es_index_preconfigured.ts

+const ES_TEST_INDEX_NAME = 'functional-test-actions-index-preconfigured';
+
+// eslint-disable-next-line import/no-default-export
+export default function indexTest({ getService }: FtrProviderContext) {


This file was copied from es_index.ts, but only tests a pre-configured action, and only that you can execute it.

pmuellr · 2020-04-14T16:53:43Z

x-pack/test/alerting_api_integration/security_and_spaces/tests/alerting/alerts.ts

@@ -165,6 +165,100 @@ instanceStateValue: true
          }
        });

+        it('should schedule task, run alert and schedule preconfigured actions when appropriate', async () => {


This is a copy of the test above it, but with a preconfigured action.

YulNaumenko

LGTM

mikecote

Code LGTM, I will open up an issue about feature controls testing on pre-configured actions.

kibanamachine · 2020-04-14T21:27:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8818d78

History

💔 Build #40720 failed 8f069f2
💚 Build #40664 succeeded a930ba2c6308ea1d05f0d2005a4bfaac216d32a4
💔 Build #40576 failed 97ae1c736dcb591bca617127fbfabc50ab5766fe
💚 Build #40572 succeeded f8deb7a6af360be12c9225375c114045a8315887

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…tic#63432) resolves elastic#63162 Most of the support for pre-configured actions has already been added to Kibana, except for one small piece. The ability for them to be executed. This PR adds that support.

…) (#63537) resolves #63162 Most of the support for pre-configured actions has already been added to Kibana, except for one small piece. The ability for them to be executed. This PR adds that support.

* master: (29 commits) Add test:jest_integration npm script (elastic#62938) [data.search.aggs] Remove service getters from agg types (AggConfig part) (elastic#62548) [Discover] Fix broken setting of bucketInterval (elastic#62939) Disable adding conditions when in alert management context. (elastic#63514) [Alerting] fixes to allow pre-configured actions to be executed (elastic#63432) adding useMemo (elastic#63504) [Maps] fix double fetch when filter pill is added (elastic#63024) [Lens] Fix missing formatting bug in "break down by" (elastic#63288) [SIEM] [Cases] Removed double pasted line (elastic#63507) [Reporting] Improve functional test steps (elastic#63259) [SIEM][CASE] Tests for server's configuration API (elastic#63099) [SIEM] [Cases] Case container unit tests (elastic#63376) [ML] Improving parsing of large uploaded files (elastic#62970) [ML] Listing global calendars on the job management page (elastic#63124) [Ingest][Endpoint] Add Ingest rest api response types for use in Endpoint (elastic#63373) Add help text to form fields (elastic#63165) [ML] Converts utils Mocha tests to Jest (elastic#63132) [Metrics UI] Refactor With* containers to hooks (elastic#59503) [NP] Migrate logstash server side code to NP (elastic#63135) Clicking cancel in saved query save modal doesn't close it (elastic#62774) ...

resolves #63162 Most of the support for pre-configured actions has already been added to Kibana, except for one small piece. The ability for them to be executed. This PR adds that support.

pmuellr added Feature:Alerting v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.8.0 labels Apr 14, 2020

[Alerting] fixes to allow pre-configured actions to be executed

8f069f2

resolves elastic#63162 Most of the support for pre-configured actions has already been added to Kibana, except for one small piece. The ability for them to be executed. This PR adds that support.

pmuellr force-pushed the alerting/pre-cfg-action-execute branch from a930ba2 to 8f069f2 Compare April 14, 2020 16:46

pmuellr marked this pull request as ready for review April 14, 2020 16:47

pmuellr requested a review from a team as a code owner April 14, 2020 16:47

pmuellr commented Apr 14, 2020

View reviewed changes

mikecote self-requested a review April 14, 2020 17:22

YulNaumenko approved these changes Apr 14, 2020

View reviewed changes

mikecote approved these changes Apr 14, 2020

View reviewed changes

mikecote mentioned this pull request Apr 14, 2020

Test pre-configured actions and see if they follow feature controls restrictions #63496

Closed

fix code after previous master merge change

8818d78

pmuellr merged commit 7677764 into elastic:master Apr 14, 2020

pmuellr mentioned this pull request Apr 14, 2020

[7.x] [Alerting] fixes to allow pre-configured actions to be executed (#63432) #63537

Merged

pmuellr added the backported label Apr 15, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Alerting] fixes to allow pre-configured actions to be executed #63432

[Alerting] fixes to allow pre-configured actions to be executed #63432

pmuellr commented Apr 14, 2020 •

edited

Loading

elasticmachine commented Apr 14, 2020

pmuellr Apr 14, 2020

pmuellr Apr 14, 2020

mikecote Apr 14, 2020 •

edited

Loading

mikecote Apr 14, 2020

pmuellr Apr 14, 2020

pmuellr Apr 14, 2020

pmuellr Apr 14, 2020

YulNaumenko left a comment

mikecote left a comment

kibanamachine commented Apr 14, 2020

[Alerting] fixes to allow pre-configured actions to be executed #63432

[Alerting] fixes to allow pre-configured actions to be executed #63432

Conversation

pmuellr commented Apr 14, 2020 • edited Loading

Checklist

elasticmachine commented Apr 14, 2020

pmuellr Apr 14, 2020

Choose a reason for hiding this comment

pmuellr Apr 14, 2020

Choose a reason for hiding this comment

mikecote Apr 14, 2020 • edited Loading

Choose a reason for hiding this comment

mikecote Apr 14, 2020

Choose a reason for hiding this comment

pmuellr Apr 14, 2020

Choose a reason for hiding this comment

pmuellr Apr 14, 2020

Choose a reason for hiding this comment

pmuellr Apr 14, 2020

Choose a reason for hiding this comment

YulNaumenko left a comment

Choose a reason for hiding this comment

mikecote left a comment

Choose a reason for hiding this comment

kibanamachine commented Apr 14, 2020

💚 Build Succeeded

History

pmuellr commented Apr 14, 2020 •

edited

Loading

mikecote Apr 14, 2020 •

edited

Loading