Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run local prettier script #63959

Merged
merged 9 commits into from
Apr 21, 2020
Merged

Conversation

mshustov
Copy link
Contributor

Summary

Prerequisite of #63735
Creates a script updating changes files to be compatible with the prettier v2 code style.
Note: To commit changes introduced by the script, a developer has to use --no-verify flag due to different code style defaults for arrow functions in prettier v1 / v2.

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.8.0 labels Apr 20, 2020
@mshustov mshustov requested a review from spalger April 20, 2020 13:31
@mshustov mshustov requested a review from a team as a code owner April 20, 2020 13:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@mshustov mshustov changed the title Run local prettier Run local prettier script Apr 20, 2020
@mshustov mshustov added the release_note:skip Skip the PR/issue when compiling release notes label Apr 20, 2020
@spalger spalger added the v8.0.0 label Apr 20, 2020
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 6ecba2c into elastic:master Apr 21, 2020
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 21, 2020
* convert eslint scripts into TS

* update settings for BWC

* add script updating styles to pretter v2

* use default prettier config

* run npx once, point to the correct head branch, do not add to git

* throw if run script not on a clear branch

* run in a batch, add logging
mshustov added a commit to mshustov/kibana that referenced this pull request Apr 21, 2020
* convert eslint scripts into TS

* update settings for BWC

* add script updating styles to pretter v2

* use default prettier config

* run npx once, point to the correct head branch, do not add to git

* throw if run script not on a clear branch

* run in a batch, add logging
mshustov added a commit that referenced this pull request Apr 21, 2020
* convert eslint scripts into TS

* update settings for BWC

* add script updating styles to pretter v2

* use default prettier config

* run npx once, point to the correct head branch, do not add to git

* throw if run script not on a clear branch

* run in a batch, add logging
mshustov added a commit that referenced this pull request Apr 21, 2020
* convert eslint scripts into TS

* update settings for BWC

* add script updating styles to pretter v2

* use default prettier config

* run npx once, point to the correct head branch, do not add to git

* throw if run script not on a clear branch

* run in a batch, add logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team v7.8.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants