-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement basic CI metric reporting #64263
Implement basic CI metric reporting #64263
Conversation
4c08bea
to
d6f28f5
Compare
0126a6f
to
a226114
Compare
Pinging @elastic/kibana-operations (Team:Operations) |
@elasticmachine merge upstream |
…stats-build-creation
} | ||
|
||
async metric(name: string, subName: string, value: number) { | ||
if (!this.config) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small thing, should this be !this.isEnabled()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could use that, but it wouldn't teach TypeScript that this.config
should be considered non-null below.
💛 Build succeeded, but was flaky
Test FailuresKibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/management/index_management/indices·js.apis management index management indices list should list all the indices with the expected properties and data enrichersStandard Out
Stack Trace
History
To update your PR or re-run it, just comment with: |
# Conflicts: # Jenkinsfile # packages/kbn-optimizer/src/cli.ts # packages/kbn-pm/dist/index.js
# Conflicts: # Jenkinsfile # packages/kbn-optimizer/src/cli.ts # packages/kbn-optimizer/src/index.ts # packages/kbn-optimizer/src/optimizer/handle_optimizer_completion.ts # packages/kbn-pm/dist/index.js # src/dev/build/tasks/build_kibana_platform_plugins.js
This PR implements some API calls and Jenkins pipeline changes that attempt to do two things:
@kbn/optimizer
runs triggered by our two distributable builds take, in the same service, using theCiStatsReporter
.This infrastructure will be expanded to collect additional metrics, and eventually will be used to report to PR authors how they are impacting key metrics with their PR.
Included some basic docs: https://github.com/spalger/kibana/blob/implement/ci-stats-build-creation/packages/kbn-dev-utils/src/ci_stats_reporter/README.md