Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] initial location map settings #64336

Merged
merged 10 commits into from
May 4, 2020
Merged

[Maps] initial location map settings #64336

merged 10 commits into from
May 4, 2020

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Apr 23, 2020

closes #15022

Screen Shot 2020-04-23 at 11 21 06 AM

@nreese nreese added release_note:enhancement [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.8.0 labels Apr 23, 2020
@nreese nreese requested a review from thomasneirynck April 23, 2020 17:23
@nreese nreese requested a review from a team as a code owner April 23, 2020 17:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@jsanz
Copy link
Member

jsanz commented Apr 24, 2020

Could the Fixed Location enable a button or helper to pick up the current coordinates and zoom?

image

@nreese
Copy link
Contributor Author

nreese commented Apr 24, 2020

Could the Fixed Location enable a button or helper to pick up the current coordinates and zoom?

Nice suggestions. I have added a button to the form to populate the fixed location from the current map view.

Screen Shot 2020-04-24 at 10 17 17 AM

@nreese
Copy link
Contributor Author

nreese commented Apr 27, 2020

@elasticmachine merge upstream

@nreese
Copy link
Contributor Author

nreese commented Apr 30, 2020

@elasticmachine merge upstream

thomasneirynck
thomasneirynck reviewed Apr 30, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool. Some minor feedback.

x-pack/plugins/maps/public/connected_components/map/mb/get_initial_view.ts Outdated Show resolved Hide resolved
x-pack/plugins/maps/public/connected_components/map/mb/view.js Show resolved Hide resolved
x-pack/plugins/maps/public/connected_components/map_settings_panel/navigation_panel.tsx Show resolved Hide resolved
x-pack/plugins/maps/public/reducers/default_map_settings.ts Outdated Show resolved Hide resolved
@alexfrancoeur
Copy link

alexfrancoeur commented Apr 30, 2020 •
edited
Loading

With #64702 potentially also in 7.8, what are the teams thoughts about adding a fourth option that is "always fit data to bounds". So as you filter down a dashboard, your map updates appropriately. I'm not sure how realistic it is, but I've clearly liked the idea for awhile 😄 #29991 (comment). Generally, feels like a separate PR / Issue

@thomasneirynck
Copy link
Contributor

Also, would you mind adding a snapshot test for the MapSettings and NavigationPanel panel? This is starting to accumulate quite a bit of UX and would be nice to have some verification.

@thomasneirynck
Copy link
Contributor

@alexfrancoeur I agree we should try #64702 for 7.8, but the auto-fit as a setting, +1 on moving that to a different PR to avoid these two blocking each other. Also, for "auto-fit-to-bounds", it introduces some complexity because we need to figure out some edge-cases (e.g. should it auto-fit if KQL query changes? Should that it auto-fit only on dashboards, or also on Maps app? If users pans/zooms, does that mean they no longer want auto-fit later when they reload/write new query, etc....). But coming soon..

@nreese
Copy link
Contributor Author

nreese commented Apr 30, 2020

@elasticmachine merge upstream

@nreese nreese requested a review from thomasneirynck May 4, 2020 14:30
@nreese
Copy link
Contributor Author

nreese commented May 4, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

thomasneirynck
thomasneirynck reviewed May 4, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

x-pack/plugins/maps/public/connected_components/map_settings_panel/navigation_panel.tsx Show resolved Hide resolved
@thomasneirynck thomasneirynck self-requested a review May 4, 2020 19:38
thomasneirynck
thomasneirynck approved these changes May 4, 2020
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will make users happy!

@nreese nreese merged commit e3b9b94 into elastic:master May 4, 2020
nreese added a commit to nreese/kibana that referenced this pull request May 4, 2020
@nreese @elasticmachine
[Maps] initial location map settings (elastic#64336)
6970ac0 
* [Maps] initial location map settings

* fix tslint

* add button to set to current view

* move button to bottom of form

* review feedback

Co-authored-by: Elastic Machine <[email protected]>
@nreese nreese mentioned this pull request May 4, 2020
Merged
nreese added a commit that referenced this pull request May 4, 2020
@nreese @elasticmachine
[Maps] initial location map settings (#64336) (#65168)
90a4a5e 
* [Maps] initial location map settings

* fix tslint

* add button to set to current view

* move button to bottom of form

* review feedback

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@alexfrancoeur
Copy link

And PM's! Yes!! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ability to user browser geolocation to center map
6 participants
@nreese @elasticmachine @jsanz @alexfrancoeur @thomasneirynck @kibanamachine