Bump karma dev-dependency from 3.1.4 to 5.0.2 #64403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
v8.0.0
release_note:skip
watson
changed the title
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
spalger
approved these changes
Apr 24, 2020
There was a problem hiding this comment.
Breaking changes between the two versions from https://github.com/karma-runner/karma/releases
- Karma plugins which rely on the fact that Karma uses Bluebird promises may break as Bluebird-specific API is no longer available on Promises returned by the Karma core
- server: Deprecated createPreprocessor removed, karma-browserify < 7 version doesn't work
- no more testing on node 8.
- Drop Support for Node 6, to make it possible to use async/await in karma codebase.
LGTM!
|
I'm not sure what the expectations might be for kibana-qa team as a reviewer. My first instinct is to just trust the Jenkins test results and LGTM it. Do we think this could break Kibana on some platforms? The easiest way for us to test that is after this is merged and there are snapshot builds. I don't want to gloss over the review. Any suggestions? |
|
@LeeDr Karma is a test runner, so I don't think so |
|
Thanks for the review |
watson
added a commit
to watson/kibana
that referenced
this pull request
Apr 27, 2020
watson
added a commit
to watson/kibana
that referenced
this pull request
Apr 27, 2020
This was brought on by merging elastic#64401, elastic#64403, elastic#64406, and elastic#64433.
watson
added a commit
that referenced
this pull request
Apr 27, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 27, 2020
* master: (78 commits) Remove SO root property index signature (elastic#64434) [ML] Functional tests - stabilize job row details validations (elastic#64503) [Ingest] Add Global settings flyout (elastic#64276) Bump cypress dev-dependency from 4.2.0 to 4.4.1 (elastic#64408) Migrate saved object of type url to kibana platform (elastic#64043) [NP] Migrate ui capabilities (elastic#64185) Bump karma-mocha dev-dependency from 1.3.0 to 2.0.0 (elastic#64407) Migrate kql_telemetry saved object registration to Kibana platform (elastic#64149) Remove SO autocreateindex error and error page (elastic#64037) Fix issue with yarn.lock (elastic#64496) Bump @hapi/boom dependency from 7.4.2 to 7.4.11 (elastic#64433) Bump gonzales-pe dev-dependency from 4.2.4 to 4.3.0 (elastic#64401) Bump karma dev-dependency from 3.1.4 to 5.0.2 (elastic#64403) Bump iedriver dev-dependency from 3.14.1 to 3.14.2 (elastic#64406) Revert "disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480)" Revert "skip flaky suite (elastic#64310)" skip flaky suite (elastic#64310) disable flaky suite (elastic#64382) (elastic#64381) (elastic#64480) [Maps] Include maps styles in embeddables factory so that they're bundled w/ consuming plugins (elastic#64460) update charts library to 18.4.2 (elastic#64438) ...
watson
added a commit
that referenced
this pull request
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.