Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fix new job wizard with multiple indices #64567

Merged
merged 2 commits into from
Apr 28, 2020
Merged

[ML] Fix new job wizard with multiple indices #64567

merged 2 commits into from
Apr 28, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Apr 27, 2020 •
edited by droberts195
Loading

If an index pattern has been created from multiple indices, the index pattern name will contain commas and so needs splitting before being added to the datafeed.
The data recognizer was already doing this, so that code has been moved to a common location so it can be used in the wizards.

Fixes #64531
Fixes #64534

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience release_note:fix backport pending :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.8.0 v7.7.1 labels Apr 27, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner April 27, 2020 19:46
@jgowdyelastic jgowdyelastic self-assigned this Apr 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@droberts195
Copy link
Contributor

droberts195 commented Apr 28, 2020 •
edited
Loading

Do you think this will also fix #64531? They seem like the same problem. I wonder if the CCS aspect of #64531 was a coincidence and not the cause of failure.

@jgowdyelastic
Copy link
Member Author

@droberts195 yes, it looks like the same problem. If the kibana index pattern is name is something like "index1,index2", it won't be split when adding to the datafeed.

peteharverson
peteharverson approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

alvarezmelissa87
alvarezmelissa87 approved these changes Apr 28, 2020
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡

@jgowdyelastic jgowdyelastic merged commit b5fb78b into elastic:master Apr 28, 2020
@jgowdyelastic jgowdyelastic deleted the fix-new-job-with-multiple-indices branch April 28, 2020 19:46
@jgowdyelastic jgowdyelastic mentioned this pull request Apr 28, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Apr 28, 2020
@jgowdyelastic @elasticmachine
[ML] Fix new job wizard with multiple indices (elastic#64567)
fd7e848 
Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
@gmmorris
Merge branch 'master' into alerting/np-migration
baa97e8 
* master: (60 commits)
  [SIEM] Create template timeline (elastic#63136)
  load react component lazily in so management section (elastic#64285)
  Cleanup .eslingignore and add target (elastic#64617)
  [Ingest] Support yaml variables in datasource (elastic#64459)
  typescript-ify portions of src/optimize (elastic#64688)
  [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546)
  Consolidate downloading plugin bundles to bootstrap script (elastic#64685)
  [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230)
  chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292)
  [Maps] fix edit filter (elastic#64586)
  [SIEM][Detections] Adds large list support using REST endpoints
  Replace a number of any-ed styled(eui*) with accurate types (elastic#64555)
  [Endpoint] Recursive resolver children (elastic#61914)
  [ML] Fix new job wizard with multiple indices (elastic#64567)
  Use short URLs for legacy plugin deprecation warning (elastic#64540)
  [Uptime] Update uptime ml job id to limit to 64 char (elastic#64394)
  [Ingest] Fix GET /enrollment-api-keys/null error (elastic#64595)
  Consolidate cross-cutting concerns between region & coordinate maps in new maps_legacy plugin (elastic#64123)
  ES UI new platform cleanup (elastic#64332)
  [Event Log] use @timestamp field for queries (elastic#64391)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Apr 29, 2020
@gmmorris
Merge branch 'alerting/np-migration' into alerting/np-migration-tests
8523508 
* alerting/np-migration: (64 commits)
  [ML] Changes Machine learning overview UI text (elastic#64625)
  [Uptime] Migrate client to New Platform (elastic#55086)
  Slim vis type timeseries (elastic#64631)
  [Telemetry] Fix inconsistent search behaviour in Advanced Settings (elastic#64510)
  removed unneeded dep and file
  [SIEM] Create template timeline (elastic#63136)
  load react component lazily in so management section (elastic#64285)
  Cleanup .eslingignore and add target (elastic#64617)
  [Ingest] Support yaml variables in datasource (elastic#64459)
  typescript-ify portions of src/optimize (elastic#64688)
  [ngSanitize] add explicit dependencies to all uses of `ngSanitize` angular module (elastic#64546)
  Consolidate downloading plugin bundles to bootstrap script (elastic#64685)
  [Maps] disable edit layer button when flyout is open for add layer or map settings (elastic#64230)
  chore(NA): add async import into infra plugin to reduce apm bundle size (elastic#63292)
  [Maps] fix edit filter (elastic#64586)
  [SIEM][Detections] Adds large list support using REST endpoints
  Replace a number of any-ed styled(eui*) with accurate types (elastic#64555)
  [Endpoint] Recursive resolver children (elastic#61914)
  [ML] Fix new job wizard with multiple indices (elastic#64567)
  Use short URLs for legacy plugin deprecation warning (elastic#64540)
  ...
jgowdyelastic added a commit that referenced this pull request Apr 29, 2020
@jgowdyelastic @elasticmachine
[ML] Fix new job wizard with multiple indices (#64567) (#64694)
7985bda 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request May 15, 2020
@jgowdyelastic @elasticmachine
[ML] Fix new job wizard with multiple indices (elastic#64567)
1386abe 
Co-authored-by: Elastic Machine <[email protected]>
@jgowdyelastic jgowdyelastic mentioned this pull request May 15, 2020
Merged
jgowdyelastic added a commit that referenced this pull request May 15, 2020
@jgowdyelastic @elasticmachine
[ML] Fix new job wizard with multiple indices (#64567) (#66699)
d8cf502 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@walterra walterra Awaiting requested review from walterra

@qn895 qn895 Awaiting requested review from qn895

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
6 participants
@jgowdyelastic @elasticmachine @kibanamachine @droberts195 @alvarezmelissa87 @peteharverson