Additional branding updates #64712
Merged
Additional branding updates #64712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elasticmachine merge upstream |
ryankeairns
force-pushed
the
rk/64695-branding-updates
branch
from
65c946e to
ce441d0
Compare
ryankeairns
added
release_note:skip
pgayvallet
approved these changes
May 1, 2020
legrego
approved these changes
May 1, 2020
There was a problem hiding this comment.
I echo @pgayvallet's sentiments here. This technically looks fine, but I personally find this change confusing. Telling new users to "login to Kibana" doesn't make a whole lot of sense anymore, when we don't give them any indication that this is actually Kibana, and not... Elastic.
streamich
approved these changes
May 5, 2020
|
Hey all, I realize these changes may seem confusing and I'm happy to talk in more detail 1:1 or through a cross team session we have scheduled during EAH. But I'm curious, as I think about the Cloud SSO login pages now, are we saying "Login to Kibana" anywhere else? We may need to apply some additional updates as well if that's the case. The way we're thinking about Kibana is changing and while developers and ops are a large portion of our audience, they aren't the only personas anymore. |
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
May 6, 2020
* branding updates * update snapshots * update loginPage snapshot * removed unused EuiText imports * update button label for exiting full screen * remove unused translations * update loading_news snapshot * update functional baseline screenshots
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 6, 2020
* master: (72 commits) add tsvb tests to Firefox suite (elastic#65425) Fix flaky ServerMetricsCollector integration test (elastic#65420) [APM] Custom links section inside the Actions menu is showing outside of the menu (elastic#65428) [ML] Adds docs_per_second to transform edit form. (elastic#65365) update apm index pattern (elastic#65424) add direct build command (elastic#65431) [ML] Adding daily_model_snapshot_retention_after_days to types and schemas (elastic#65417) [chore] Improve request cancelation handling in vis embeddable (elastic#65057) [Alerting] migrates acceptance and functional test fixtures to KP (elastic#64888) [ML] Fixes reordering in view by selection when overall cell selected (elastic#65290) Additional branding updates (elastic#64712) Remove redundant formatting of percentage column (elastic#64948) [SIEM][CASE] Configuration pages UI redesign (elastic#65355) New nav (elastic#64018) [Ingest pipelines] Address copy feedback (elastic#65175) bug fixing (elastic#65387) skip whole suite blocking snapshots (elastic#65377) add related event generation to ancestor nodes (fixes a bug) (elastic#64950) [Canvas] move files from legacy/plugins to plugins (elastic#65283) [SIEM] template timeline UI (elastic#64439) ...
ryankeairns
added a commit
that referenced
this pull request
May 6, 2020
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Jun 2, 2020
* branding updates * update snapshots * update loginPage snapshot * removed unused EuiText imports * update button label for exiting full screen * remove unused translations * update loading_news snapshot * update functional baseline screenshots # Conflicts: # src/core/public/chrome/ui/header/header_logo.tsx # x-pack/plugins/translations/translations/zh-CN.json
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Jun 2, 2020
* branding updates * update snapshots * update loginPage snapshot * removed unused EuiText imports * update button label for exiting full screen * remove unused translations * update loading_news snapshot * update functional baseline screenshots
ryankeairns
added a commit
to ryankeairns/kibana
that referenced
this pull request
Jun 2, 2020
* branding updates * update snapshots * update loginPage snapshot * removed unused EuiText imports * update button label for exiting full screen * remove unused translations * update loading_news snapshot * update functional baseline screenshots # Conflicts: # src/core/public/chrome/ui/header/header_logo.tsx # x-pack/plugins/translations/translations/zh-CN.json
ryankeairns
added a commit
that referenced
this pull request
Jun 3, 2020
* Additional branding updates (#64712) * branding updates * update snapshots * update loginPage snapshot * removed unused EuiText imports * update button label for exiting full screen * remove unused translations * update loading_news snapshot * update functional baseline screenshots # Conflicts: # src/core/public/chrome/ui/header/header_logo.tsx # x-pack/plugins/translations/translations/zh-CN.json * update snapshots * update more snapshots * clean then update snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64695
Related to #64018
^ Waiting for new nav to merge first
Summary
Branding changes requested by Product; pretty minor in terms of code impacted.
Following is a list of what has been changed (screenshots below):
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyScreenshots
Remove subtitle 'Your window into the Elastic Stack' from login and sample data screens
Use Elastic loading logo in What's New
Use Elastic logo and remove 'Elastic Kibana' title from 'Exit full screen' button
Use Elastic logo in header/home button; Change favicon to Elastic logo
Changing loading screen to read 'Loading Elastic' instead of 'Loading Elastic Kibana'