Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Canvas] Updates function reference docs #64741

Merged
merged 3 commits into from
May 4, 2020
Merged

[Canvas] Updates function reference docs #64741

merged 3 commits into from
May 4, 2020

Conversation

cqliu1
Copy link
Contributor

@cqliu1 cqliu1 commented Apr 29, 2020 •
edited
Loading

Summary

[skip-ci]

This updates the Canvas function reference documentation to include changes introduced in 7.7.

Changes:

  • adds openLinkInNewTab arg in markdown
  • adds function reference for savedMap, savedLens, savedVisualizations, timeRange, and mapCenter
  • adds examples for demodata, esdocs, and essql

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@cqliu1 cqliu1 added release_note:skip Skip the PR/issue when compiling release notes review Team:Docs v7.7.0 v7.8.0 v8.0.0 labels Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-docs (Team:Docs)

@cqliu1 cqliu1 added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Apr 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-canvas (Team:Canvas)

@cqliu1 cqliu1 requested review from a team and KOTungseth April 29, 2020 04:11
KOTungseth
KOTungseth approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@KOTungseth KOTungseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating this content! I made a few comments around consistency, but otherwise, LGTM!

docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
docs/canvas/canvas-function-reference.asciidoc Outdated Show resolved Hide resolved
timductive
timductive approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@timductive timductive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cqliu1 cqliu1 merged commit 0580440 into elastic:master May 4, 2020
@cqliu1 cqliu1 deleted the docs/update-fn-ref branch May 4, 2020 17:07
This was referenced May 4, 2020
Merged
Merged
cqliu1 added a commit to cqliu1/kibana that referenced this pull request May 4, 2020
@cqliu1
[Canvas] Updates function reference docs (elastic#64741)
90e046f
cqliu1 added a commit that referenced this pull request May 4, 2020
@cqliu1
[7.x] [Canvas] Updates function reference docs (#64741) (#65125)
4be8446
cqliu1 added a commit that referenced this pull request May 4, 2020
@cqliu1
[7.7] [Canvas] Updates function reference docs (#64741) (#65126)
d53e576
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KOTungseth KOTungseth KOTungseth approved these changes

@timductive timductive timductive approved these changes

Assignees
No one assigned
Labels
impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort release_note:skip Skip the PR/issue when compiling release notes review Team:Docs Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas v7.7.0 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cqliu1 @elasticmachine @timductive @KOTungseth