load react component lazily to reduce entry bundle #65267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
added
chore
performance
release_note:skip
afharo
approved these changes
May 5, 2020
|
|
||
| // required for lazy loading | ||
| // eslint-disable-next-line import/no-default-export | ||
| export { TelemetryManagementSection as default }; |
There was a problem hiding this comment.
Super NIT: why the export { X as Y } instead of the straight export default TelemetryManagementSection; format?
Suggested change
| export { TelemetryManagementSection as default }; | |
| export default TelemetryManagementSection; |
afharo
approved these changes
May 5, 2020
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
mshustov
added a commit
to mshustov/kibana
that referenced
this pull request
May 5, 2020
* load react component lazily to reduce entry bundle * address comments
mshustov
added a commit
that referenced
this pull request
May 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Parent issue: #62263
We strive to keep the entry bundle as small as possible to speed up Kibana load + bootstrap time.
telemetry_management_section.plugin.jsbundle is loaded whenever a user opens Kibana and should be lightweight. This PR adds lazy loading to reducetelemetry_management_section.plugin.jsbundle size to load the main chunk of code by demand when the section is mounted.telemetry_management_section.plugin.jssize before:966Kbtelemetry_management_section.plugin.jssize after:8.7Kb