Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Hide chrome until an app is mounting or mounted to avoid FOC on chromeless apps (#65036) #65299

Merged
merged 1 commit into from
May 5, 2020

Conversation

pgayvallet
Copy link
Contributor

Backports the following commits to 7.x:

…eless apps (elastic#65036)

* hidden chrome until an application is mounted

* emits currentAppId$ before executing mount handler

* address comments
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-xpack-agent / Plugin Functional Tests.x-pack/test/plugin_api_integration/test_suites/event_log/public_api_integration·ts.event_log Event Log public API should support pagination for events

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has failed 2 times on tracked branches: https://github.com/elastic/kibana/issues/64812

[00:00:00]       │
[00:00:00]         └-: event_log
[00:00:00]           └-> "before all" hook
[00:00:00]           └-: Event Log public API
[00:00:00]             └-> "before all" hook
[00:00:00]             └-> should allow querying for events by Saved Object
[00:00:00]               └-> "before each" hook: global before each
[00:00:00]               │ debg Logging Event for Saved Object e517be8e-01d7-4089-a421-dfe48ce7724d
[00:00:00]               │ proc [kibana]   log   [17:41:39.784] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: e517be8e-01d7-4089-a421-dfe48ce7724d {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"e517be8e-01d7-4089-a421-dfe48ce7724d"}]},"message":"test 2020-05-05T17:41:39.711Z"}
[00:00:00]               │ proc [kibana]   log   [17:41:39.821] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/e517be8e-01d7-4089-a421-dfe48ce7724d] not found
[00:00:01]               │ proc [kibana]   log   [17:41:40.898] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object e517be8e-01d7-4089-a421-dfe48ce7724d
[00:00:01]               │ proc [kibana]   log   [17:41:40.901] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:01]               │ proc [kibana]   log   [17:41:40.904] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:40.899Z","end":"2020-05-05T17:41:40.899Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"e517be8e-01d7-4089-a421-dfe48ce7724d"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:39.711Z","@timestamp":"2020-05-05T17:41:40.899Z","ecs":{"version":"1.5.0"}}
[00:00:01]               │ debg Logging Event for Saved Object e517be8e-01d7-4089-a421-dfe48ce7724d
[00:00:01]               │ proc [kibana]   log   [17:41:41.014] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: e517be8e-01d7-4089-a421-dfe48ce7724d {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"e517be8e-01d7-4089-a421-dfe48ce7724d"}]},"message":"test 2020-05-05T17:41:39.711Z"}
[00:00:01]               │ proc [kibana]   log   [17:41:41.057] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:01]               │ proc [kibana]   log   [17:41:41.060] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:01]               │ debg calling /api/event_log/event_log_test/e517be8e-01d7-4089-a421-dfe48ce7724d/_find
[00:00:01]               │ proc [kibana]   log   [17:41:41.062] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:41.058Z","end":"2020-05-05T17:41:41.058Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"e517be8e-01d7-4089-a421-dfe48ce7724d"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:39.711Z","@timestamp":"2020-05-05T17:41:41.059Z","ecs":{"version":"1.5.0"}}
[00:00:01]               └- ✓ pass  (1.5s) "event_log Event Log public API should allow querying for events by Saved Object"
[00:00:01]             └-> should support pagination for events
[00:00:01]               └-> "before each" hook: global before each
[00:00:01]               │ debg Logging Event for Saved Object 576b121f-6d50-48c3-b160-0a805e2ead38
[00:00:01]               │ proc [kibana]   log   [17:41:41.349] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 576b121f-6d50-48c3-b160-0a805e2ead38 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.260Z"}
[00:00:01]               │ proc [kibana]   log   [17:41:41.376] [info][eventLogFixture][event_log_fixture][plugins][plugins] log event error: Error: Saved object [event_log_test/576b121f-6d50-48c3-b160-0a805e2ead38] not found
[00:00:02]               │ proc [kibana]   log   [17:41:41.917] [info][eventLogFixture][event_log_fixture][plugins][plugins] created saved object 576b121f-6d50-48c3-b160-0a805e2ead38
[00:00:02]               │ proc [kibana]   log   [17:41:41.919] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ debg Logging Event for Saved Object 576b121f-6d50-48c3-b160-0a805e2ead38
[00:00:02]               │ debg Logging Event for Saved Object 576b121f-6d50-48c3-b160-0a805e2ead38
[00:00:02]               │ debg Logging Event for Saved Object 576b121f-6d50-48c3-b160-0a805e2ead38
[00:00:02]               │ debg Logging Event for Saved Object 576b121f-6d50-48c3-b160-0a805e2ead38
[00:00:02]               │ debg Logging Event for Saved Object 576b121f-6d50-48c3-b160-0a805e2ead38
[00:00:02]               │ proc [kibana]   log   [17:41:41.921] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:41.918Z","end":"2020-05-05T17:41:41.918Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.260Z","@timestamp":"2020-05-05T17:41:41.918Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [17:41:42.069] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 576b121f-6d50-48c3-b160-0a805e2ead38 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.260Z"}
[00:00:02]               │ proc [kibana]   log   [17:41:42.083] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 576b121f-6d50-48c3-b160-0a805e2ead38 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.260Z"}
[00:00:02]               │ proc [kibana]   log   [17:41:42.093] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 576b121f-6d50-48c3-b160-0a805e2ead38 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.261Z"}
[00:00:02]               │ proc [kibana]   log   [17:41:42.102] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 576b121f-6d50-48c3-b160-0a805e2ead38 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.260Z"}
[00:00:02]               │ proc [kibana]   log   [17:41:42.117] [info][eventLogFixture][event_log_fixture][plugins][plugins] test fixture: log event: 576b121f-6d50-48c3-b160-0a805e2ead38 {"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.260Z"}
[00:00:02]               │ proc [kibana]   log   [17:41:42.121] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [17:41:42.122] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [17:41:42.125] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [17:41:42.126] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [17:41:42.128] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.121Z","end":"2020-05-05T17:41:42.121Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.260Z","@timestamp":"2020-05-05T17:41:42.121Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [17:41:42.128] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.125Z","end":"2020-05-05T17:41:42.125Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.260Z","@timestamp":"2020-05-05T17:41:42.125Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [17:41:42.134] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [17:41:42.136] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [17:41:42.138] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.135Z","end":"2020-05-05T17:41:42.135Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.261Z","@timestamp":"2020-05-05T17:41:42.135Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [17:41:42.144] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [17:41:42.145] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ proc [kibana]   log   [17:41:42.147] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.144Z","end":"2020-05-05T17:41:42.144Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.260Z","@timestamp":"2020-05-05T17:41:42.144Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ proc [kibana]   log   [17:41:42.150] [info][eventLogFixture][event_log_fixture][plugins][plugins] found existing saved object
[00:00:02]               │ proc [kibana]   log   [17:41:42.151] [info][eventLogFixture][event_log_fixture][plugins][plugins] logged
[00:00:02]               │ debg calling /api/event_log/event_log_test/576b121f-6d50-48c3-b160-0a805e2ead38/_find
[00:00:02]               │ proc [kibana]   log   [17:41:42.153] [info][eventLog][plugins] event logged: {"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.150Z","end":"2020-05-05T17:41:42.150Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.260Z","@timestamp":"2020-05-05T17:41:42.150Z","ecs":{"version":"1.5.0"}}
[00:00:02]               │ debg --- retry.try error: expected 4 to equal 6
[00:00:03]               │ debg calling /api/event_log/event_log_test/576b121f-6d50-48c3-b160-0a805e2ead38/_find
[00:00:03]               │ debg --- retry.try failed again with the same message...
[00:00:03]               │ debg calling /api/event_log/event_log_test/576b121f-6d50-48c3-b160-0a805e2ead38/_find
[00:00:03]               │ debg calling /api/event_log/event_log_test/576b121f-6d50-48c3-b160-0a805e2ead38/_find?per_page=3
[00:00:03]               │ debg calling /api/event_log/event_log_test/576b121f-6d50-48c3-b160-0a805e2ead38/_find?per_page=3&page=2
[00:00:03]               │ debg failed to match {"foundEvents":[{"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.135Z","end":"2020-05-05T17:41:42.135Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.261Z","@timestamp":"2020-05-05T17:41:42.135Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.144Z","end":"2020-05-05T17:41:42.144Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.260Z","@timestamp":"2020-05-05T17:41:42.144Z","ecs":{"version":"1.5.0"}},{"event":{"provider":"event_log_fixture","action":"test","start":"2020-05-05T17:41:42.150Z","end":"2020-05-05T17:41:42.150Z","duration":0},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}],"server_uuid":"5b2de169-2785-441b-ae8c-186a1936b17d"},"message":"test 2020-05-05T17:41:41.260Z","@timestamp":"2020-05-05T17:41:42.150Z","ecs":{"version":"1.5.0"}}],"expectedEvents":[{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.260Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.260Z"},{"event":{"provider":"event_log_fixture","action":"test"},"kibana":{"saved_objects":[{"rel":"primary","namespace":"default","type":"event_log_test","id":"576b121f-6d50-48c3-b160-0a805e2ead38"}]},"message":"test 2020-05-05T17:41:41.261Z"}]}
[00:00:03]               └- ✖ fail: "event_log Event Log public API should support pagination for events"
[00:00:03]               │

Stack Trace

{ Error: expected 'test 2020-05-05T17:41:41.261Z' to sort of equal 'test 2020-05-05T17:41:41.260Z'
    at Assertion.assert (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (/dev/shm/workspace/kibana/packages/kbn-expect/expect.js:244:8)
    at forEach (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:174:40)
    at Array.forEach (<anonymous>)
    at assertEventsFromApiMatchCreatedEvents (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:169:19)
    at Context.it (test/plugin_api_integration/test_suites/event_log/public_api_integration.ts:77:7)
  actual: 'test 2020-05-05T17:41:41.261Z',
  expected: 'test 2020-05-05T17:41:41.260Z',
  showDiff: true }

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@pgayvallet pgayvallet merged commit 290b938 into elastic:7.x May 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants