Cross-platform CLI execution of "npm start".

[bevacqua]

Tested it on my local Windows computer.

Fixes #4962

[bevacqua]

@w33ble Could you check this out? 💯

[w33ble]

Were you using git bash? This change seems to work there, but not from the standard cmd.exe prompt in Windows. There, I just get:

`sh` is not recognized as an internal or external command,
operable program or batch file.

Granted, this is better than it was, but doesn't seem like the real fix. I'm ok merging this change though, if you add a note in the docs that git-bash is required on Windows to use npm start

[bevacqua]

@w33ble Yes. I was. I think it's a decent compromise. Back when I developed on Windows this was pretty much a requirement for Windows boxes, so I wouldn't worry much.

[w33ble]

I'm ok merging this change though, if you add a note in the docs that git-bash is required on Windows to use npm start

Can you add that requirement to the docs? Just update CONTRIBUTING.md and add a note around the part that recommends npm start that if you're on Windows, you'll need to be using git-bash.

[bevacqua]

There we go!

[w33ble]

we recommend

We don't recommend it, it's a hard requirement ;). Maybe something like:

On Windows, you'll need to run this in Git Bash, Cygwin, or a something similar that exposes the sh command.

[bevacqua]

There you go, @w33ble. Squashed.

[w33ble]

Sorry for all the back and forth on this tiny change ;)

🏆

[bevacqua]

Don't be. Push for quality! 💯