Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Fixing watch creation #65956

Merged
merged 1 commit into from
May 11, 2020
Merged

[ML] Fixing watch creation #65956

merged 1 commit into from
May 11, 2020

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented May 10, 2020 •
edited
Loading

Adds isActive which is needed for watch creation.

Functional tests are needed to stop something like this happening again. will add in a follow up PR.

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review release_note:fix :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 v7.8.0 v7.7.1 labels May 10, 2020
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner May 10, 2020 17:27
@jgowdyelastic jgowdyelastic self-assigned this May 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

darnautov
darnautov approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic merged commit af102af into elastic:master May 11, 2020
@jgowdyelastic jgowdyelastic deleted the fix-watch-creation branch May 11, 2020 09:00
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request May 11, 2020
@jgowdyelastic
[ML] Fixing watch creation (elastic#65956)
c93790c
@jgowdyelastic jgowdyelastic mentioned this pull request May 11, 2020
Merged
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request May 11, 2020
@jgowdyelastic
[ML] Fixing watch creation (elastic#65956)
78a1eab
@jgowdyelastic jgowdyelastic mentioned this pull request May 11, 2020
Merged
jgowdyelastic added a commit that referenced this pull request May 11, 2020
@jgowdyelastic
[ML] Fixing watch creation (#65956) (#65980)
f59df00
jgowdyelastic added a commit that referenced this pull request May 11, 2020
@jgowdyelastic
[ML] Fixing watch creation (#65956) (#65979)
d0f9a16
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request May 15, 2020
@jgowdyelastic
[ML] Fixing watch creation (elastic#65956)
38601e5
@jgowdyelastic jgowdyelastic mentioned this pull request May 15, 2020
Merged
jgowdyelastic added a commit that referenced this pull request May 15, 2020
@jgowdyelastic
[ML] Fixing watch creation (#65956) (#66700)
6071a5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@darnautov darnautov darnautov approved these changes

@walterra walterra Awaiting requested review from walterra

Assignees

@jgowdyelastic jgowdyelastic

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml release_note:fix review v7.7.1 v7.8.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jgowdyelastic @elasticmachine @kibanamachine @darnautov @peteharverson