Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] Use Kibana logger for proper server-side logging #66017

Merged
merged 3 commits into from
May 11, 2020
Merged

[Ingest] Use Kibana logger for proper server-side logging #66017

merged 3 commits into from
May 11, 2020

Conversation

skh
Copy link
Contributor

@skh skh commented May 11, 2020 •
edited
Loading

Summary

This adds core Kibana logging functionality to the Ingest Manager app context.

This is a prerequisite for several bug fixes being worked on, among them #64067

How to test this

  • Add a logger somewhere on the server and verify that the log entry appears in the log. When running Kibana locally, this is the console output in the terminal where you started Kibana.
  • Messages should be prefixed with the standard logging prefix, like this:
server    log   [14:59:03.386] [info][ingestManager][plugins] Attempting installation of package nginx-0.0.3.
  • the example output above was produced by d31c890 . I reverted this because it belongs to an actual bugfix.

@skh skh added bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v7.9.0 v8.0.0 labels May 11, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@skh skh marked this pull request as ready for review May 11, 2020 13:29
@skh skh requested review from a team, neptunian and jfsiii May 11, 2020 13:29
@skh skh changed the title 64067 robust package installation [Ingest] Use Kibana logger for proper server-side logging May 11, 2020
jfsiii
jfsiii approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@jfsiii jfsiii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usage in d31c890 LGTM

nchaulet
nchaulet approved these changes May 11, 2020
View reviewed changes
Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@skh skh merged commit a1a157d into elastic:master May 11, 2020
@skh skh mentioned this pull request May 11, 2020
Merged
skh added a commit to skh/kibana that referenced this pull request May 11, 2020
@skh
[Ingest] Use Kibana logger for proper server-side logging (elastic#66017
26fb6a9 
)

* Add logger to app context.
skh added a commit to skh/kibana that referenced this pull request May 11, 2020
@skh
[Ingest] Use Kibana logger for proper server-side logging (elastic#66017
402f5cd 
)

* Add logger to app context.
@skh skh mentioned this pull request May 11, 2020
Merged
@skh skh deleted the 64067-robust-package-installation branch May 11, 2020 16:21
skh added a commit that referenced this pull request May 12, 2020
@skh @elasticmachine
[Ingest] Use Kibana logger for proper server-side logging (#66017) (#…
193f6f7 
…66068)

* Add logger to app context.

Co-authored-by: Elastic Machine <[email protected]>
skh added a commit that referenced this pull request May 12, 2020
@skh @elasticmachine
[Ingest] Use Kibana logger for proper server-side logging (#66017) (#…
b96e57d 
…66067)

* Add logger to app context.

Co-authored-by: Elastic Machine <[email protected]>
@skh skh mentioned this pull request May 15, 2020
Closed
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nchaulet nchaulet nchaulet approved these changes

@jfsiii jfsiii jfsiii approved these changes

@neptunian neptunian Awaiting requested review from neptunian

Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@skh @elasticmachine @kibanamachine @jfsiii @nchaulet