[Endpoint] connect policy response ui to api #66093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkiino
added
Feature:Endpoint
|
Pinging @elastic/endpoint-app-team (Feature:Endpoint) |
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
kevinlog
approved these changes
May 12, 2020
|
After this PR, we'll put in @nnamdifrankie PR next - #65962. It makes an adjustment to the API schema and makes view changes as well. |
paul-tavares
approved these changes
May 12, 2020
| export const policyResponseLoading = (state: Immutable<HostState>): boolean => | ||
| state.policyResponseLoading; | ||
|
|
||
| export const policyResponseError = (state: Immutable<HostState>) => state.policyResponseError; |
There was a problem hiding this comment.
Should add explicit return type:
Suggested change
| export const policyResponseError = (state: Immutable<HostState>) => state.policyResponseError; | |
| export const policyResponseError = (state: Immutable<HostState>): boolean => state.policyResponseError; |
| truncateText: true, | ||
| render: (ip: string[]) => { | ||
| return ( | ||
| <EuiToolTip content={ip.toString().replace(',', ', ')} anchorClassName="eui-fullWidth"> |
There was a problem hiding this comment.
Suggestion: do the ip.toString().replace(',', ', ') once and store value in a variable - then use variable in the two places below.
parkiino
added a commit
to parkiino/kibana
that referenced
this pull request
May 12, 2020
[Endpoint] Connect policy response UI to API
parkiino
added a commit
that referenced
this pull request
May 12, 2020
[Endpoint] Connect policy response UI to API Co-authored-by: Elastic Machine <[email protected]>
parkiino
changed the title
💔 Build Failed
Failed CI StepsTest FailuresKibana Pipeline / kibana-xpack-agent / Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/reporting_management/report_delete_pagination·ts.reporting management app Delete reports "before all" hook for "Confirm single report deletion works"Standard OutStack TraceKibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/endpoint/policy·ts.apis Endpoint plugin Endpoint policy api GET /api/endpoint/policy_response "before all" hook for "should return one policy response for host"Standard OutStack TraceKibana Pipeline / kibana-xpack-agent / X-Pack API Integration Tests.x-pack/test/api_integration/apis/endpoint/policy·ts.apis Endpoint plugin Endpoint policy api GET /api/endpoint/policy_response "before all" hook for "should return one policy response for host"Standard OutStack TraceHistory
To update your PR or re-run it, just comment with: |
devinmcafee
reviewed
May 16, 2020
| <EuiToolTip content={ip.toString().replace(',', ', ')} anchorClassName="eui-fullWidth"> | ||
| <EuiText size="s" className="eui-fullWidth"> | ||
| <span className="eui-textTruncate eui-fullWidth"> | ||
| {ip.toString().replace(',', ', ')} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
For maintainers