Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fix/config pull issues #6711

Closed
wants to merge 12 commits into from
Closed

Conversation

rashidkpc
Copy link
Contributor

This is basically the same as #6657, buy with linting fixed and the couple other bugs that @w33ble and i found taken care of.

@rashidkpc
Copy link
Contributor Author

Test failures are totally valid:

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if missing a name property FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260046:1

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if missing a button group FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260053:1

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if multiple button groups FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260060:1

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive incorrect use should throw if button group not direct child FAILED
    expected fn to throw an exception
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.throwException@http://localhost:5610/bundles/tests.bundle.js:235720:1
    @http://localhost:5610/bundles/tests.bundle.js:260067:1

.
Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive injecting extensions should append to end then order == 0 FAILED
    expected 3 to equal 4
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.equal@http://localhost:5610/bundles/tests.bundle.js:235765:1
    @http://localhost:5610/bundles/tests.bundle.js:260096:9

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive injecting extensions should append to end then order > 0 FAILED
    expected 3 to equal 4
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.equal@http://localhost:5610/bundles/tests.bundle.js:235765:1
    @http://localhost:5610/bundles/tests.bundle.js:260104:9

Firefox 45.0.0 (Ubuntu 0.0.0) navbar directive injecting extensions should append to end then order < 0 FAILED
    expected 3 to equal 4
    Assertion.prototype.assert@http://localhost:5610/bundles/tests.bundle.js:235645:14
    Assertion.prototype.equal@http://localhost:5610/bundles/tests.bundle.js:235765:1
    @http://localhost:5610/bundles/tests.bundle.js:260112:9

@w33ble
Copy link
Contributor

w33ble commented Mar 30, 2016

All those tests are related to the navbar injection, which doesn't work the same way anymore.

The test cases should probably be translated to the kbn-top-nav or navbar-extensions directive though, as it should work the same there.


EDIT: I think you really just need to check the kbn-top-nav throws if it doesn't have a name attribute. All the tests around the button group checks aren't valid anymore.

@rashidkpc rashidkpc changed the title Pulltweaks/6657 Fix fix/config pull issues Mar 30, 2016
@rashidkpc
Copy link
Contributor Author

Closing in place of #6657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants