-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fix/config pull issues #6711
Conversation
…cope, and be a bit more transparent, also some code cleanup
…g extensions, added top navbar to every page
…ve timepicker opening button
Test failures are totally valid:
|
All those tests are related to the navbar injection, which doesn't work the same way anymore. The test cases should probably be translated to the kbn-top-nav or navbar-extensions directive though, as it should work the same there. EDIT: I think you really just need to check the kbn-top-nav throws if it doesn't have a name attribute. All the tests around the button group checks aren't valid anymore. |
Closing in place of #6657 |
This is basically the same as #6657, buy with linting fixed and the couple other bugs that @w33ble and i found taken care of.