[Metrics UI] Show current view's name in toolbar #68231
Conversation
phillipb
added
release_note:enhancement
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💔 Build Failed
Failed CI StepsTo update your PR or re-run it, just comment with: |
| @@ -95,10 +112,7 @@ export function SavedViewsToolbarControls<ViewState>(props: Props<ViewState>) { | |||
| /> | |||
| </EuiButtonEmpty> | |||
| <EuiButtonEmpty iconType="importAction" onClick={loadViews} data-test-subj="loadViews"> | |||
There was a problem hiding this comment.
I feel like the importAction icon doesn't make sense anymore now that this button doesn't say "Load." Maybe something that communicates "This is the current view" better?
grid seems like the closest thing in EUI to the look of the waffle map. node might also work even though it's not a square.
| @@ -95,10 +112,7 @@ export function SavedViewsToolbarControls<ViewState>(props: Props<ViewState>) { | |||
| /> | |||
| </EuiButtonEmpty> | |||
| <EuiButtonEmpty iconType="importAction" onClick={loadViews} data-test-subj="loadViews"> | |||
| <FormattedMessage | |||
| defaultMessage="Load" | |||
| id="xpack.infra.waffle.savedViews.loadViewsLabel" | |||
There was a problem hiding this comment.
Looks like removing this is throwing an i18n error
|
Hi @phillipb Should this be included in the 7.9.0 release notes? I don't see it listed here: https://github.com/elastic/kibana/blob/0afaba21b39709739086e2aaa3a88a8a1bea855b/docs/CHANGELOG.asciidoc |
Summary
Give the user more context by showing the current view's name. Fixes: #65836