Use Search API in Vega #68257

alexwizp · 2020-06-04T14:15:37Z

Summary

The old elasticsearch client is deprecated and we need to switch away from it. We should use App Arch's Search API instead to send the raw DSL in Vega.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

alexwizp · 2020-06-05T08:36:28Z

@elasticmachine merge upstream

elasticmachine · 2020-06-05T08:36:30Z

merge conflict between base and head

# Conflicts: # src/plugins/data/public/search/fetch/get_search_params.ts

elasticmachine · 2020-06-05T08:53:35Z

Pinging @elastic/kibana-app (Team:KibanaApp)

alexwizp · 2020-06-08T06:41:01Z

@elasticmachine merge upstream

lizozom

Added a couple of comments on implementation.
Didn't test Vega yet.

lizozom · 2020-06-08T08:02:55Z

src/plugins/vis_type_vega/public/vega_request_handler.ts

-        maxAge: 4 * 1000,
-      });
+    if (!searchAPI) {
+      searchAPI = new SearchAPI({ search: getData().search }, abortSignal);


Why do you need getData if this function gets data plugin as a dependency?

lizozom · 2020-06-08T08:04:35Z

src/plugins/data/public/search/search_service.ts

@@ -171,6 +172,13 @@ export class SearchService implements Plugin<ISearchSetup, ISearchStart> {
          return new SearchSource({}, searchSourceDependencies);
        },
      },
+      searchParams: {


I think it would be really simple to add this function as a utility, passing in core from the caller.
I don't see any reason to have this as part of the contract, as it's only used to migrate old requests to the new search service format, and won't be a part of the API long term

@liza-mae np, will move it into static contract. My idea was to bind the required dependencies...

Wrong liza :)

lizozom · 2020-06-08T08:04:45Z

src/plugins/data/public/search/fetch/get_search_params.ts

@@ -53,3 +54,18 @@ export function getPreference(config: IUiSettingsClient) {
 export function getTimeout(esShardTimeout: number) {
  return esShardTimeout > 0 ? `${esShardTimeout}ms` : undefined;
 }
+
+export function getSearchParamsFromRequest(


Thanks for adding this!

pgayvallet

LGTM for SOM plugin changes

pgayvallet · 2020-06-08T08:30:50Z

...ment/public/management_section/objects_table/__snapshots__/saved_objects_table.test.tsx.snap

+      "searchParams": Object {
+        "createFromRequest": [MockFunction],
+      },


That's not the first PR that is forced to update this snapshot. This should not be needed. Gonna fix the test to just assert existence of the Flyout component. Snapshot testing the props has really low value here, and behavior is already covered in FTR test anyway

Created #68489

lizozom · 2020-06-08T14:06:34Z

src/plugins/data/public/public.api.md

@@ -641,6 +642,23 @@ export function getQueryLog(uiSettings: IUiSettingsClient, storage: IStorageWrap
 // @public (undocumented)
 export function getSearchErrorType({ message }: Pick<SearchError, 'message'>): "UNSUPPORTED_QUERY" | undefined;

+// Warning: (ae-missing-release-tag) "getSearchParamsFromRequest" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal)


Maybe mark this as @internal?

@lizozom not sure, becase we use it at least in 2 different plugins: data, vis_type_vega

lizozom

LGTM
Haven't checked out to test

# Conflicts: # src/plugins/data/public/public.api.md

kibanamachine · 2020-06-09T10:17:20Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 7a92618

History

💚 Build #52370 succeeded 9adc521
💚 Build #52355 succeeded cc8caff
💚 Build #52306 succeeded adac8b741c00a75f67762a636087f7bc016eb69b
💚 Build #52018 succeeded 8ad6ff6
💚 Build #51875 succeeded 1e752c5

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

alexwizp · 2020-06-09T11:20:01Z

ping @elastic/kibana-app

stratoula

Code LGTM, have tested it on chrome, safari and ff. Old vega visualizations work as expected and also new ones.

* Use Search API in Vega * fix PR comments * fix PR comments

* Use Search API in Vega * fix PR comments * fix PR comments Co-authored-by: Elastic Machine <[email protected]>

* master: (22 commits) Partial revert of "Sync Kerberos + Anonymous access tests with the latest `security/_authenticate` API (user roles now include roles of anonymous user)." (elastic#68624) adapt some snapshot test (elastic#68489) [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (elastic#68486) [skip test] apis Kerberos security Kerberos authentication finishing SPNEGO should properly set cookie and authenticate user [SIEM][Exceptions] - ExceptionsViewer UI component part 2 (elastic#68294) Surface data streams in Index Management. (elastic#67806) Fix edit datasource not working following changes in elastic#67234 (elastic#68583) [Logs + Metrics UI] Clean up async plugin initialization (elastic#67654) APM Storybook fixes (elastic#68671) Upgrade EUI to v24.1.0 (elastic#68141) [ML] DF Analytics: Creation wizard part 2 (elastic#68462) [Uptime] Fix race on overview page query (elastic#67843) Prefer using npm_execpath when spawning Yarn (elastic#68673) [Security] [Cases] Attach timeline to existing case (elastic#68580) Use Search API in Vega (elastic#68257) [Component templates] Table view (elastic#68031) [Uptime] Added relative date info in cert status column (elastic#67612) [Endpoint] Re-enable Functional test case for Endpoint related pages (elastic#68445) run page_load_metrics tests in visual regresssion jobs (elastic#68570) Enable exhaustive-deps; correct any lint warnings (elastic#68453) ...

alexwizp force-pushed the 67584 branch from 7928dce to 60fd8d0 Compare June 4, 2020 16:27

Use Search API in Vega

1e752c5

alexwizp force-pushed the 67584 branch from 60fd8d0 to 1e752c5 Compare June 4, 2020 18:10

Merge remote-tracking branch 'upstream/master' into 67584

8ad6ff6

# Conflicts: # src/plugins/data/public/search/fetch/get_search_params.ts

alexwizp requested review from lizozom, flash1293 and stratoula June 5, 2020 08:51

alexwizp self-assigned this Jun 5, 2020

alexwizp added v7.9.0 v8.0.0 labels Jun 5, 2020

alexwizp added Feature:Vega Vega visualizations Feature:Search Querying infrastructure in Kibana Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration labels Jun 5, 2020

alexwizp marked this pull request as ready for review June 5, 2020 08:53

alexwizp requested a review from a team June 5, 2020 08:53

alexwizp requested review from a team as code owners June 5, 2020 08:53

lizozom reviewed Jun 8, 2020

View reviewed changes

pgayvallet approved these changes Jun 8, 2020

View reviewed changes

pgayvallet mentioned this pull request Jun 8, 2020

SOM plugin: adapt some snapshot tests #68489

Merged

alexwizp added 2 commits June 8, 2020 14:31

fix PR comments

f17ddb0

Merge remote-tracking branch 'upstream/master' into 67584

cc8caff

alexwizp force-pushed the 67584 branch from adac8b7 to cc8caff Compare June 8, 2020 11:32

fix PR comments

9adc521

lizozom reviewed Jun 8, 2020

View reviewed changes

lizozom approved these changes Jun 8, 2020

View reviewed changes

Merge remote-tracking branch 'upstream/master' into 67584

7a92618

# Conflicts: # src/plugins/data/public/public.api.md

stratoula approved these changes Jun 9, 2020

View reviewed changes

alexwizp merged commit 5d8de7a into elastic:master Jun 9, 2020

alexwizp mentioned this pull request Jun 9, 2020

[7.x] Use Search API in Vega (#68257) #68689

Merged

alexwizp added a commit to alexwizp/kibana that referenced this pull request Jun 9, 2020

Use Search API in Vega (elastic#68257)

abfe3b1

* Use Search API in Vega * fix PR comments * fix PR comments

alexwizp added a commit that referenced this pull request Jun 10, 2020

Use Search API in Vega (#68257) (#68689)

8685f2a

* Use Search API in Vega * fix PR comments * fix PR comments Co-authored-by: Elastic Machine <[email protected]>

alexwizp mentioned this pull request Jun 29, 2020

[Vega] Cancel discarded searches #46352

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use Search API in Vega #68257

Use Search API in Vega #68257

alexwizp commented Jun 4, 2020

alexwizp commented Jun 5, 2020

elasticmachine commented Jun 5, 2020

elasticmachine commented Jun 5, 2020

alexwizp commented Jun 8, 2020

lizozom left a comment

lizozom Jun 8, 2020

lizozom Jun 8, 2020

alexwizp Jun 8, 2020

lizozom Jun 8, 2020

alexwizp Jun 8, 2020

lizozom Jun 8, 2020

pgayvallet left a comment

pgayvallet Jun 8, 2020

pgayvallet Jun 8, 2020

lizozom Jun 8, 2020

alexwizp Jun 8, 2020

lizozom left a comment

kibanamachine commented Jun 9, 2020

alexwizp commented Jun 9, 2020

stratoula left a comment

Use Search API in Vega #68257

Use Search API in Vega #68257

Conversation

alexwizp commented Jun 4, 2020

Summary

Checklist

For maintainers

alexwizp commented Jun 5, 2020

elasticmachine commented Jun 5, 2020

elasticmachine commented Jun 5, 2020

alexwizp commented Jun 8, 2020

lizozom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pgayvallet left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lizozom left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 9, 2020

💚 Build Succeeded

History

alexwizp commented Jun 9, 2020

stratoula left a comment

Choose a reason for hiding this comment