[TSVB] Add support for histogram type

src/plugins/vis_type_timeseries/common/constants.ts

@@ -18,3 +18,35 @@
  */
 
 export const MAX_BUCKETS_SETTING = 'metrics:max_buckets';
+
+// Tests Constants
+export const UI_RESTRICTIONS = { '*': true };
+export const INDEX_PATTERN = 'some-pattern';
+export const FIELDS = {
+  [INDEX_PATTERN]: [
+    {
+      type: 'date',
+      name: '@timestamp',
+    },
+    {
+      type: 'number',
+      name: 'system.cpu.user.pct',
+    },
+    {
+      type: 'histogram',
+      name: 'histogram_value',
+    },
+  ],
+};
+export const METRIC = {
+  type: 'avg',
+  field: 'system.cpu.user.pct',
+};
+export const SERIES = {
+  metrics: [METRIC],
+};
+export const PANEL = {
+  type: 'timeseries',
+  index_pattern: INDEX_PATTERN,
+  series: SERIES,
+};

src/plugins/vis_type_timeseries/common/metric_types.js

@@ -27,6 +27,8 @@ export const METRIC_TYPES = {
   VARIANCE: 'variance',
   SUM_OF_SQUARES: 'sum_of_squares',
   CARDINALITY: 'cardinality',
+  VALUE_COUNT: 'value_count',
+  AVERAGE: 'avg',
 };
 
 export const EXTENDED_STATS_TYPES = [

src/plugins/vis_type_timeseries/public/application/components/aggs/histogram_support.test.js

@@ -0,0 +1,84 @@
+/*
+ * Licensed to Elasticsearch B.V. under one or more contributor
+ * license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright
+ * ownership. Elasticsearch B.V. licenses this file to you under
+ * the Apache License, Version 2.0 (the "License"); you may
+ * not use this file except in compliance with the License.
+ * You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import React from 'react';
+import { mountWithIntl } from 'test_utils/enzyme_helpers';
+import { Agg } from './agg';
+import { FieldSelect } from './field_select';
+import { FIELDS, METRIC, SERIES, PANEL } from '../../../../common/constants';
+const runTest = (aggType, name, test) => {
+  describe(aggType, () => {
+    const metric = {
+      ...METRIC,
+      type: aggType,
+      field: 'histogram_value',
+    };
+    const series = { ...SERIES, metrics: [metric] };
+    const panel = { ...PANEL, series };
+
+    it(name, () => {
+      const wrapper = mountWithIntl(
+        <div>
+          <Agg
+            onAdd={jest.fn()}
+            onChange={jest.fn()}
+            onDelete={jest.fn()}
+            panel={panel}
+            fields={FIELDS}
+            model={metric}
+            series={series}
+            siblings={series.metrics}
+            dragHandleProps={{}}
+          />
+        </div>
+      );
+      test(wrapper);
+    });
+  });
+};
+
+describe('Histogram Types', () => {
+  describe('supported', () => {
+    const shouldHaveHistogramSupport = (aggType) => {
+      runTest(aggType, 'supports', (wrapper) =>
+        expect(wrapper.find(FieldSelect).at(0).props().restrict).toContain('histogram')
+      );
+    };
+    shouldHaveHistogramSupport('avg');
+    shouldHaveHistogramSupport('value_count');
+    shouldHaveHistogramSupport('percentile');
+    shouldHaveHistogramSupport('percentile_rank');
+  });
+  describe('not supported', () => {
+    const shouldNotHaveHistogramSupport = (aggType) => {
+      runTest(aggType, 'does not support', (wrapper) =>
+        expect(wrapper.find(FieldSelect).at(0).props().restrict).not.toContain('histogram')
+      );
+    };
+    shouldNotHaveHistogramSupport('cardinality');
+    shouldNotHaveHistogramSupport('max');
+    shouldNotHaveHistogramSupport('min');
+    shouldNotHaveHistogramSupport('sum');
+    shouldNotHaveHistogramSupport('variance');
+    shouldNotHaveHistogramSupport('sum_of_squares');
+    shouldNotHaveHistogramSupport('std_deviation');
+    shouldNotHaveHistogramSupport('positive_rate');
+    shouldNotHaveHistogramSupport('top_hit');
+  });
+});

src/plugins/vis_type_timeseries/public/application/components/aggs/percentile.js

@@ -36,7 +36,7 @@ import { FormattedMessage } from '@kbn/i18n/react';
 import { KBN_FIELD_TYPES } from '../../../../../../plugins/data/public';
 import { Percentiles, newPercentile } from './percentile_ui';
 
-const RESTRICT_FIELDS = [KBN_FIELD_TYPES.NUMBER];
+const RESTRICT_FIELDS = [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM];
 
 const checkModel = (model) => Array.isArray(model.percentiles);
 

src/plugins/vis_type_timeseries/public/application/components/aggs/percentile_rank/percentile_rank.tsx

@@ -41,7 +41,7 @@ import { IFieldType, KBN_FIELD_TYPES } from '../../../../../../../plugins/data/p
 import { MetricsItemsSchema, PanelSchema, SeriesItemsSchema } from '../../../../../common/types';
 import { DragHandleProps } from '../../../../types';
 
-const RESTRICT_FIELDS = [KBN_FIELD_TYPES.NUMBER];
+const RESTRICT_FIELDS = [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM];
 
 interface PercentileRankAggProps {
   disableDelete: boolean;

src/plugins/vis_type_timeseries/public/application/components/aggs/positive_rate.js

@@ -123,7 +123,7 @@ export const PositiveRateAgg = (props) => {
             <FieldSelect
               fields={props.fields}
               type={model.type}
-              restrict={KBN_FIELD_TYPES.NUMBER}
+              restrict={[KBN_FIELD_TYPES.NUMBER]}
               indexPattern={indexPattern}
               value={model.field}
               onChange={handleSelectChange('field')}

src/plugins/vis_type_timeseries/public/application/components/aggs/std_agg.js

@@ -36,12 +36,23 @@ import { FormattedMessage } from '@kbn/i18n/react';
 import { KBN_FIELD_TYPES } from '../../../../../../plugins/data/public';
 import { METRIC_TYPES } from '../../../../../../plugins/vis_type_timeseries/common/metric_types';
 
+function getSupportedFieldsByMetricType(type) {
+  switch (type) {
+    case METRIC_TYPES.CARDINALITY:
+      return Object.values(KBN_FIELD_TYPES).filter((type) => type !== KBN_FIELD_TYPES.HISTOGRAM);
+    case METRIC_TYPES.VALUE_COUNT:
+    case METRIC_TYPES.AVERAGE:
+      return [KBN_FIELD_TYPES.NUMBER, KBN_FIELD_TYPES.HISTOGRAM];
+    default:
+      return [KBN_FIELD_TYPES.NUMBER];
+  }
+}
+
 export function StandardAgg(props) {
   const { model, panel, series, fields, uiRestrictions } = props;
   const handleChange = createChangeHandler(props.onChange, model);
   const handleSelectChange = createSelectHandler(handleChange);
-  const restrictFields = model.type === METRIC_TYPES.CARDINALITY ? [] : [KBN_FIELD_TYPES.NUMBER];
-
+  const restrictFields = getSupportedFieldsByMetricType(model.type);
   const indexPattern =
     (series.override_index_pattern && series.series_index_pattern) || panel.index_pattern;
   const htmlId = htmlIdGenerator();