Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Security] Rename old xpack.siem kibana config to xpack.securitySolution #69874

Merged
merged 2 commits into from
Jun 25, 2020
Merged

[Security] Rename old xpack.siem kibana config to xpack.securitySolution #69874

merged 2 commits into from
Jun 25, 2020

Conversation

XavierM
Copy link
Contributor

@XavierM XavierM commented Jun 25, 2020 •
edited
Loading

Summary

Thanks for @joshdover insomnia ;) but I think it is most related to his work ethics. Anyway, He just saved us from a big problem here.

This PR is to rename our old property in kibana config file like xpack.siem.enabled to xpack.securitySolution.enabled.

To test this PR, just add a property in your kibana.dev.config like xpack.siem.signalsIndex and you should see that

image

Alos the doc is here -> https://github.com/elastic/kibana/blob/master/src/core/MIGRATION.md#handle-plugin-configuration-deprecations

@XavierM XavierM added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 labels Jun 25, 2020
@XavierM XavierM requested review from FrankHassanabad and spong June 25, 2020 02:52
@XavierM XavierM requested review from a team as code owners June 25, 2020 02:52
@XavierM XavierM self-assigned this Jun 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM requested a review from joshdover June 25, 2020 02:52
spong
spong approved these changes Jun 25, 2020
View reviewed changes
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out locally and tested with legacy xpack.siem.* configuration -- verified below deprecation warning, and also that the feature worked as expected. Also verified functionality using the new configuration xpack.securitySolution.* as well. LGTM! Thanks @XavierM & @joshdover 🙂

Note: I did see three occurrences of the deprecation warning during startup -- not sure if this is expected or perhaps a result of having a deeper logging level?

log [20:58:03.999] [warning][config][deprecation] "xpack.siem.signalsIndex" is deprecated and has been replaced by "xpack.securitySolution.signalsIndex"

server log [21:00:57.053] [warning][config][deprecation] "xpack.siem.signalsIndex" is deprecated and has been replaced by "xpack.securitySolution.signalsIndex"

optmzr log [21:00:57.202] [warning][config][deprecation] "xpack.siem.signalsIndex" is deprecated and has been replaced by "xpack.securitySolution.signalsIndex"

@spong
Copy link
Member

spong commented Jun 25, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

joshdover
joshdover approved these changes Jun 25, 2020
View reviewed changes
Copy link
Contributor

@joshdover joshdover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, glad we caught this early enough :)

@joshdover
Copy link
Contributor

Checked out locally and tested with legacy xpack.siem.* configuration -- verified below deprecation warning, and also that the feature worked as expected. Also verified functionality using the new configuration xpack.securitySolution.* as well. LGTM! Thanks @XavierM & @joshdover 🙂

Note: I did see three occurrences of the deprecation warning during startup -- not sure if this is expected or perhaps a result of having a deeper logging level?

log [20:58:03.999] [warning][config][deprecation] "xpack.siem.signalsIndex" is deprecated and has been replaced by "xpack.securitySolution.signalsIndex"

server log [21:00:57.053] [warning][config][deprecation] "xpack.siem.signalsIndex" is deprecated and has been replaced by "xpack.securitySolution.signalsIndex"

optmzr log [21:00:57.202] [warning][config][deprecation] "xpack.siem.signalsIndex" is deprecated and has been replaced by "xpack.securitySolution.signalsIndex"

These are only in development where we have multiple processes running. Should not see this in production builds.

@joshdover
Copy link
Contributor

Have we updated any related documentation?

@XavierM XavierM added release_note:fix and removed release_note:skip Skip the PR/issue when compiling release notes labels Jun 25, 2020
@XavierM
Copy link
Contributor Author

XavierM commented Jun 25, 2020

Have we updated any related documentation?

@benskelker can you make sure we get the doc updated

@XavierM XavierM merged commit ff3ee41 into elastic:master Jun 25, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 25, 2020
@gmmorris
Merge branch 'master' into alerting/migrate-old-alerting-consumer
045c68e 
* master: (90 commits)
  [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513)
  [SIEM] Replace WithSource with useWithSource hook (elastic#68722)
  [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708)
  rename old siem kibana config to securitySolution (elastic#69874)
  Remove unused Resolver code (elastic#69914)
  [Observability] Fixing dynamic return type based on the appName (elastic#69894)
  [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419)
  Fixes special clicks and 3rd party icon sizes in nav (elastic#69767)
  [APM] Catch annotations index permission error and log warning (elastic#69881)
  [Endpoint][Ingest Manager] minor code cleanup (elastic#69844)
  [Logs UI] Logs ui context menu (elastic#69915)
  Index pattern serialize and de-serialize (elastic#68844)
  [QA] Unskip functional tests (elastic#69760)
  [SIEM][Detection Engine] - Update DE to work with new exceptions schema (elastic#69715)
  Fixes elastic#69639: Ignore url.url fields above 2048 characters (elastic#69863)
  PR: Provide limit warnings to user when API limits are reached. (elastic#69590)
  [Maps] Remove broken button (elastic#69853)
  Makes usage collection methods available on start (elastic#69836)
  [SIEM][CASE] Improve Jira's labelling (elastic#69892)
  [Logs UI] Access ML via the programmatic plugin API (elastic#68905)
  ...
@XavierM XavierM mentioned this pull request Jun 25, 2020
Merged
XavierM added a commit to XavierM/kibana that referenced this pull request Jun 25, 2020
@XavierM @elasticmachine
rename old siem kibana config to securitySolution (elastic#69874)
45c76b8 
Co-authored-by: Elastic Machine <[email protected]>
XavierM added a commit that referenced this pull request Jun 25, 2020
@XavierM @elasticmachine
rename old siem kibana config to securitySolution (#69874) (#69989)
49985ed 
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
gmmorris added a commit to gmmorris/kibana that referenced this pull request Jun 26, 2020
@gmmorris
Merge branch 'master' into alerting/consumer-based-rbac
2e75199 
* master:
  [Encrypted Saved Objects] Adds support for migrations in ESO (elastic#69513)
  [SIEM] Replace WithSource with useWithSource hook (elastic#68722)
  [Endpoint]EMT-451: add ability to filter endpoint metadata based on presence of unenrolled events (elastic#69708)
  rename old siem kibana config to securitySolution (elastic#69874)
  Remove unused Resolver code (elastic#69914)
  [Observability] Fixing dynamic return type based on the appName (elastic#69894)
  [SECURITY SOLUTION][INGEST] Task/endpoint list tests (elastic#69419)
  Fixes special clicks and 3rd party icon sizes in nav (elastic#69767)
  [APM] Catch annotations index permission error and log warning (elastic#69881)
  [Endpoint][Ingest Manager] minor code cleanup (elastic#69844)
  [Logs UI] Logs ui context menu (elastic#69915)
  Index pattern serialize and de-serialize (elastic#68844)
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spong spong spong approved these changes

@joshdover joshdover joshdover approved these changes

@FrankHassanabad FrankHassanabad Awaiting requested review from FrankHassanabad

Assignees

@XavierM XavierM

Labels
release_note:fix Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:SIEM v7.9.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@XavierM @elasticmachine @spong @kibanamachine @joshdover @MindyRS