Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics UI] UX improvements for saved views #69910

Merged
merged 16 commits into from
Jun 29, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
phillipb committed Jun 29, 2020
commit cc75db7bfa4b538f7e915f6de9ec6bb124276515
Original file line number Diff line number Diff line change
@@ -108,7 +108,7 @@ export function SavedViewManageViewsFlyout<ViewState>({
[deleteView]
);

const renderMakeDefaultction = useCallback(
const renderMakeDefaultAction = useCallback(
(item: SavedView<ViewState>) => {
const isDefault = item.id === defaultViewId;
return (
@@ -142,7 +142,7 @@ export function SavedViewManageViewsFlyout<ViewState>({
actions: [
{
available: () => true,
render: renderMakeDefaultction,
render: renderMakeDefaultAction,
},
{
available: (item: SavedView<ViewState>) => true,