Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] move Metrics API to start (#69787) #70056

Merged
merged 1 commit into from
Jun 26, 2020

Conversation

mshustov
Copy link
Contributor

Backports the following commits to 7.x:

* move metrics to start

* update plugins accordingly

* update docs

* update legacy code

Co-authored-by: Elastic Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💛 Build succeeded, but was flaky


Test Failures

Kibana Pipeline / kibana-oss-agent / Plugin Functional Tests.test/plugin_functional/test_suites/core_plugins/logging·ts.core plugins plugin logging writes info_json context to custom JSON appender

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

[00:00:00]       │
[00:01:21]         └-: core plugins
[00:01:21]           └-> "before all" hook
[00:03:54]           └-: plugin logging
[00:03:54]             └-> "before all" hook
[00:03:54]             └-> does not write to custom appenders when not configured
[00:03:54]               └-> "before each" hook: global before each
[00:03:54]               └-> "before each" hook
[00:03:54]               │ proc [kibana]   log   [12:18:57.258] [info][core_logging][debug_json][plugins] i go to the default appender!
[00:03:54]               └- ✓ pass  (46ms) "core plugins plugin logging does not write to custom appenders when not configured"
[00:03:54]             └-> writes debug_json context to custom JSON appender
[00:03:54]               └-> "before each" hook: global before each
[00:03:54]               └-> "before each" hook
[00:03:54]               └- ✓ pass  (40ms) "core plugins plugin logging writes debug_json context to custom JSON appender"
[00:03:54]             └-> writes info_json context to custom JSON appender
[00:03:54]               └-> "before each" hook: global before each
[00:03:54]               └-> "before each" hook
[00:03:54]               │ info Taking screenshot "/dev/shm/workspace/kibana/test/functional/screenshots/failure/core plugins plugin logging writes info_json context to custom JSON appender.png"
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [dev_tools] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[INFO] http://localhost:6121/9007199254740991/bundles/kbn-ui-shared-deps/kbn-ui-shared-deps.js 452:106112 "INFO: 2020-06-26T12:18:57Z
[00:03:55]               │        Adding connection to http://localhost:6121/elasticsearch
[00:03:55]               │
[00:03:55]               │      "
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [management] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [rendering] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [custom-app-route] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [chromeless] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [appleave1] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [appleave2] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [foo] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ debg browser[WARNING] http://localhost:6121/9007199254740991/bundles/core_legacy_compat.bundle.js 2405:20 "App [bar] is using deprecated mount context. Use core.getStartServices() instead."
[00:03:55]               │ info Current URL is: http://localhost:6121/app/core_legacy_compat
[00:03:55]               │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 950:16 "Reporting user-agent."
[00:03:55]               │ debg browser[DEBUG] http://localhost:6121/9007199254740991/bundles/plugin/usageCollection/usageCollection.plugin.js 950:16 "Reporting application changed to core_legacy_compat"
[00:03:55]               │ info Saving page source to: /dev/shm/workspace/kibana/test/plugin_functional/failure_debug/html/core plugins plugin logging writes info_json context to custom JSON appender.html
[00:03:55]               └- ✖ fail: "core plugins plugin logging writes info_json context to custom JSON appender"
[00:03:55]               │

Stack Trace

{ Error: expected [] to sort of equal [ { level: 'INFO',
    context: 'plugins.core_logging.info_json',
    message: 'log2' } ]
    at Assertion.assert (packages/kbn-expect/expect.js:100:11)
    at Assertion.eql (packages/kbn-expect/expect.js:244:8)
    at Context.it (test/plugin_functional/test_suites/core_plugins/logging.ts:96:40)
  actual: '[]',
  expected:
   '[\n  {\n    "context": "plugins.core_logging.info_json"\n    "level": "INFO"\n    "message": "log2"\n  }\n]',
  showDiff: true }

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov merged commit 7f46f11 into elastic:7.x Jun 26, 2020
@mshustov mshustov deleted the backport/7.x/pr-69787 branch June 26, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants