[Security Solution] Template unit tests #72399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/siem (Team:SIEM) |
angorayc
added
the
release_note:skip
💚 Build Succeeded
Expand to view the summary
Build stats
|
11 tasks
angorayc
commented
Jul 22, 2020
x-pack/plugins/security_solution/server/lib/timeline/routes/utils/compare_timelines_status.ts
Outdated
Show resolved
Hide resolved
|
@elasticmachine merge upstream |
cnasikas
reviewed
Jul 22, 2020
...urity_solution/public/detections/components/rules/pre_packaged_rules/update_callout.test.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
Jul 22, 2020
...ck/plugins/security_solution/public/detections/pages/detection_engine/rules/helpers.test.tsx
Show resolved
Hide resolved
cnasikas
reviewed
Jul 22, 2020
| const templateTimelineVersion = this.templateTimelineObject?.getVersion; | ||
| return ( | ||
| templateTimelineVersion == null || | ||
| (isInteger(templateTimelineVersion) && !this.isTemplateVersionConflict) |
There was a problem hiding this comment.
If the templateTimelineVersion is of type string but a number (example: '123') then the function will return false. Is that intended?
There was a problem hiding this comment.
Yeah, It only takes number as templateTimelineVersion.
|
@elasticmachine merge upstream |
💚 Build SucceededBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
cnasikas
approved these changes
Jul 28, 2020
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Jul 28, 2020
* add unit test for failure cases * add unit tests * update wording * fix error when update template without ttid or ttversion * fix unit test * add comment * review Co-authored-by: Elastic Machine <[email protected]>
angorayc
added a commit
to angorayc/kibana
that referenced
this pull request
Jul 28, 2020
* add unit test for failure cases * add unit tests * update wording * fix error when update template without ttid or ttversion * fix unit test * add comment * review Co-authored-by: Elastic Machine <[email protected]>
angorayc
added a commit
that referenced
this pull request
Jul 28, 2020
* add unit test for failure cases * add unit tests * update wording * fix error when update template without ttid or ttversion * fix unit test * add comment * review Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
angorayc
added a commit
that referenced
this pull request
Jul 28, 2020
* add unit test for failure cases * add unit tests * update wording * fix error when update template without ttid or ttversion * fix unit test * add comment * review Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
MindyRS
added
the
Team: SecuritySolution
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
To verify this PR:
Download timelines_export.txt
Change
.txtinto.ndjsonImport the file and see if it's created successfully as a custom template.
Checklist
Delete any items that are not applicable to this PR.
Documentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityThis renders correctly on smaller devices using a responsive layout. (You can test this in your browserThis was checked for cross-browser compatibilityFor maintainers
This was checked for breaking API changes and was labeled appropriately