Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.9][Lens] Fix Edit Url #72532

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Conversation

ThomThomson
Copy link
Contributor

@ThomThomson ThomThomson commented Jul 20, 2020

Summary

Tiny fix for #72522

Main Branch #72533

Checklist

Delete any items that are not applicable to this PR.

- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibility
- [ ] This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
- [ ] This was checked for cross-browser compatibility

For maintainers

@ThomThomson ThomThomson added Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens v7.9.0 labels Jul 20, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@ThomThomson ThomThomson changed the title [Lens] Fix Edit Url [7.9][Lens] Fix Edit Url Jul 20, 2020
@ThomThomson ThomThomson mentioned this pull request Jul 20, 2020
1 task
Copy link
Contributor

@majagrubic majagrubic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me 3 minutes to understand where the change is 😂 Haven't tested locally.

@ThomThomson ThomThomson merged commit b3635f7 into elastic:7.9 Jul 21, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Dashboard Dashboard related features Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.9.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Lens] Edit lens url in dashboard is invalid when copied or opened in new window
4 participants