Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add margin #72542

Merged
merged 1 commit into from
Jul 21, 2020
Merged

[Security Solution] Add margin #72542

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion x-pack/plugins/security_solution/public/resolver/view/process_event_dot.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ const UnstyledProcessEventDot = React.memo(
alignSelf: 'flex-start',
background: colorMap.resolverBackground,
display: `${isShowingEventActions ? 'flex' : 'none'}`,
margin: 0,
margin: '2px 0 0 0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❔ This kicks it down a hairline, right? I got it to stop doing the rendering thing (But I didn't test it very much) by setting contain: layout on the button above. Maybe something to keep in mind later if someone wants to nudge it back where it was. It's a weird issue and AFAICT one of those things that "shouldn't happen" by the book.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it does. The padding at the top of the popover was 2px so I added the margin to account for that. Yea, it shouldn't because even with the padding, it should still respect each elements space in the layout. 🤷‍♂️

padding: 0,
}}
>
Expand Down