Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code coverage] add iframe embedded and enterprise search tests #73267

Merged
merged 1 commit into from
Jul 27, 2020
Merged

[code coverage] add iframe embedded and enterprise search tests #73267

merged 1 commit into from
Jul 27, 2020

Conversation

dmlemeshko
Copy link
Member

@dmlemeshko dmlemeshko commented Jul 27, 2020 •
edited
Loading

Summary

Add 2 configs with functional tests to Code Coverage set:

elastic+kibana+qa-research #54 Test Results Jenkins 2020-07-27 15-05-43

tested with https://kibana-ci.elastic.co/job/elastic+kibana+qa-research/54/

@dmlemeshko dmlemeshko added v8.0.0 backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team labels Jul 27, 2020
@dmlemeshko dmlemeshko marked this pull request as ready for review July 27, 2020 14:31
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-qa (Team:QA)

@dmlemeshko dmlemeshko requested a review from LeeDr July 27, 2020 14:32
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Build metrics

✅ unchanged

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

LeeDr
LeeDr approved these changes Jul 27, 2020
View reviewed changes
Copy link

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - more test coverage data !

@dmlemeshko dmlemeshko merged commit 25856ed into elastic:master Jul 27, 2020
@dmlemeshko dmlemeshko deleted the add-configs-for-code-coverage branch January 31, 2022 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeeDr LeeDr LeeDr approved these changes

Assignees
No one assigned
Labels
backport:skip This commit does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:QA Team label for QA Team v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmlemeshko @elasticmachine @kibanamachine @LeeDr