Remove deprecated nav UI and chrome tabs API. #7595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,7 @@ import metadata from 'ui/metadata'; | |||
| import 'babel/polyfill'; | |||
| import $ from 'jquery'; | |||
| import 'ui/timefilter'; | |||
| import 'ui/notify'; | |||
There was a problem hiding this comment.
This registers a bunch of notification stuff with Angular. Originally this was executed as a side-effect of requiring in /api/tabs (below), which imported TabCollection, which imported Tab, which imported ui/notify.
|
test this please ... sorry for the noise, we're trying to sort out some issues with the new kibana-ci status updates |
cjcenizal
force-pushed
the
chore/remove-deprecated-tabs-nav
branch
2 times, most recently
from
63351f5 to
c5a3f1b
Compare
|
jenkins, test this |
1 similar comment
|
jenkins, test this |
cjcenizal
force-pushed
the
chore/remove-deprecated-tabs-nav
branch
from
c5a3f1b to
df4ace4
Compare
|
Ran it, didn't see any issues, and I didn't catch any problems with the code you removed. LGTM. |
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
…d-tabs-nav Remove deprecated nav UI and chrome tabs API. Former-commit-id: b258ddc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this is all 4.x code that's no longer used in 5.