[ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra #78209

qn895 · 2020-09-22T20:01:16Z

Summary

This PR replaces machine learning URLs from the previous hash-based paths to the new paths as part of the migration to BrowserRouter #72013. Updates were made to APM, Infra, and Security solutions plugins.

Changes include:

We expose the mlUrlGenerator on ML plugin’s contract. Then consumers would declare that they need ml as a dependency and would access mlUrlGenerator from deps.mlUrlGenerator passed in start or setup hooks.
Updating the Anomaly Detection job list to accept list of jobIds in the URL. This is because some plugins are passing in array of jobIds, and this is not currently supported.
Fall back to go to basePath/app/ml if ml.urlGenerator is not available to generate the urls for some reasons.

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios

…obsCallout

…security solution

…place-hash # Conflicts: # x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLJobLink.test.tsx # x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.test.tsx # x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.tsx # x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/useTimeSeriesExplorerHref.test.ts # x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/useTimeSeriesExplorerHref.ts # x-pack/plugins/ml/public/plugin.ts

…place-hash

x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.tsx

…place-hash # Conflicts: # x-pack/plugins/ml/public/plugin.ts

[ML] Add import

jgowdyelastic

LGTM

…place-hash

rylnd

@qn895 these changes look good to me! With the additional state added by this hook we're getting some warnings from jest, but I've got a commit that fixes those here. Up to you whether to include those changes here or not, I can always follow up afterward.

rylnd · 2020-09-30T20:15:42Z

x-pack/plugins/security_solution/public/common/lib/kibana/kibana_react.mock.ts

@@ -113,6 +114,12 @@ export const createStartServicesMock = (): StartServices => {
    },
    security,
    storage,
+    ml: {


Not critical, but: it would be nice if ml provided a mock for this contract!

Thanks Ryland! Updated here 1c390c1

kibanamachine · 2020-09-30T22:35:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1c390c1

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
`ml`	1186	+1	1185

async chunks size

id	value	diff	baseline
`apm`	4.1MB	+935.0B	4.1MB
`infra`	4.3MB	+8.0B	4.3MB
`ml`	10.5MB	-16.7KB	10.5MB
`securitySolution`	10.3MB	+801.0B	10.3MB
total		-15.0KB

page load bundle size

id	value	diff	baseline
`apm`	44.3KB	+229.0B	44.1KB
`ml`	58.5KB	+18.3KB	40.3KB
`securitySolution`	581.2KB	+229.0B	581.0KB
total		+18.7KB

History

💔 Build #78057 failed 4903e35
💔 Build #77574 failed 7ccc111
💔 Build #77419 failed b24dcdb
💔 Build #77071 failed 6da3cb3
💚 Build #76313 succeeded 9be734d

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* master: (36 commits) [I18n] fix eui tokens (elastic#78951) Changed the color of the confirm button in trusted app deletion dialog. (elastic#78768) Make the actual Vislib import async (elastic#78949) Fix ML conditionals links Cypress tests (elastic#78568) [Drilldowns][Docs] Communicate the visualization types that support drilldowns (elastic#78761) [UX] Improve page-load axis (elastic#78392) [SECURITY SOLUTIONS] Map embeddable working with index patterns selection (elastic#78610) Data plugin README (elastic#78750) [TSVB] Request validation error: [panels.0.series.0.metrics.0.percentiles.1.value] (elastic#79009) fixing api test (elastic#78964) [Task names in TaskManager] Rename "telemetry" to "usage" (elastic#78129) [Loggers] Rename "telemetry" to "usage" (elastic#78130) [Usage Collection] [schema] `ui_metric` (elastic#78827) [Actions][Jira] Set parent issue for Sub-task issue type (elastic#78772) [Discover] Unskip doc link functional test (elastic#78600) [ML] Functional tests - stabilize calendar edit tests (elastic#78950) [UX] Improve page responsive (elastic#78759) [QA][Code Coverage] Team Assignment Docs Update (elastic#78890) [ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra (elastic#78209) [ts] enable "resolveJsonModule" and disable existing failures (elastic#78855) ...

kibanamachine · 2020-10-02T23:54:39Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 78209 or prevent reminders by adding the backport:skip label.

…ecurity, and Infra (elastic#78209) * [ML] Adds ability to pass multiple jobIds to job management url * [ML][APM] Update links to jobs management page for MLLink and LegacyJobsCallout * [ML][APM] Update useTimeSeriesExplorerHref * [ML][APM] Update tests * [ML][APM] Move test from useTimeSeriesExplorerHref to MLJobLink.test.tsx * [ML][Infra] Update ML links in infra to non-hash paths * [ML] Move MlUrlGenerator registration outside of licensing block for security solution * [ML][Security] Update ml links in security * [ML][APM] Update test snapshots * [ML][APM] Update snapshots * [ML][Security solution] Update tests * [ML] Update MLLink to include globalState * [ML] Update useTimeSeriesExplorerHref * [ML] Update apm and security_solution to use useMlHref hook * [ML] Update APM to use useUrlParams hook, update security solution hook * [ML] Update tests, fix duplicate imports * [ML] Update imports, remove ml exports to shared cause it's not needed [ML] Add import * [ML] Update snapshot * [ML] Fix warnings for jobs_table.test.tsx Co-authored-by: Elastic Machine <[email protected]> # Conflicts: # x-pack/plugins/apm/public/utils/testHelpers.tsx

…PM, Security, and Infra (#78209) (#79487) Co-authored-by: Elastic Machine <[email protected]>

smith · 2020-10-21T23:14:19Z

Tested in Safari, Chrome, and Firefox:

qn895 added 15 commits September 21, 2020 15:10

[ML] Adds ability to pass multiple jobIds to job management url

0064270

[ML][APM] Update links to jobs management page for MLLink and LegacyJ…

357c42b

…obsCallout

[ML][APM] Update useTimeSeriesExplorerHref

ec58132

[ML][APM] Update tests

d9ed2a5

[ML][APM] Move test from useTimeSeriesExplorerHref to MLJobLink.test.tsx

6696c06

[ML][Infra] Update ML links in infra to non-hash paths

a897190

[ML] Move MlUrlGenerator registration outside of licensing block for …

dcf92e0

…security solution

[ML][Security] Update ml links in security

76ffb79

[ML][APM] Update test snapshots

cdd5045

[ML][APM] Update snapshots

b9258f2

[ML][Security solution] Update tests

02cb4c6

[ML] Update MLLink to include globalState

d37abef

Merge remote-tracking branch 'upstream/master' into ml-exernal-url-re…

937ef9d

…place-hash

[ML] Update useTimeSeriesExplorerHref

9be734d

qn895 added :ml refactoring v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 22, 2020

qn895 requested review from Kerry350, rylnd, ogupte and spong September 22, 2020 20:01

qn895 self-assigned this Sep 22, 2020

qn895 marked this pull request as ready for review September 22, 2020 23:47

qn895 requested review from a team as code owners September 22, 2020 23:47

qn895 added 2 commits September 28, 2020 11:43

[ML] Update APM to use useUrlParams hook, update security solution hook

c890c97

Merge remote-tracking branch 'upstream/master' into ml-exernal-url-re…

7ccc111

…place-hash

sorenlouv reviewed Sep 28, 2020

View reviewed changes

x-pack/plugins/apm/public/components/shared/Links/MachineLearningLinks/MLLink.tsx Show resolved Hide resolved

qn895 added 3 commits September 29, 2020 10:20

[ML] Update tests, fix duplicate imports

7e66d56

Merge remote-tracking branch 'upstream/master' into ml-exernal-url-re…

3ad1996

…place-hash # Conflicts: # x-pack/plugins/ml/public/plugin.ts

[ML] Update imports, remove ml exports to shared cause it's not needed

4903e35

[ML] Add import

sorenlouv approved these changes Sep 30, 2020

View reviewed changes

jgowdyelastic approved these changes Sep 30, 2020

View reviewed changes

qn895 added 2 commits September 30, 2020 15:34

Merge remote-tracking branch 'upstream/master' into ml-exernal-url-re…

f57f4e2

…place-hash

[ML] Update snapshot

5e09d95

rylnd approved these changes Sep 30, 2020

View reviewed changes

[ML] Fix warnings for jobs_table.test.tsx

1c390c1

qn895 merged commit 2344dcf into elastic:master Sep 30, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 2, 2020

weltenwort mentioned this pull request Oct 5, 2020

[Logs UI] Use the ML plugin's url generator for cross-app links #79426

Closed

qn895 mentioned this pull request Oct 5, 2020

[7.x][ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra (#78209) #79487

Merged

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 5, 2020

qn895 added a commit that referenced this pull request Oct 5, 2020

[7.x][ML] Migrate machine learning URLs to BrowserRouter format for A…

2876807

…PM, Security, and Infra (#78209) (#79487) Co-authored-by: Elastic Machine <[email protected]>

qn895 deleted the ml-exernal-url-replace-hash branch October 7, 2020 15:23

sorenlouv added the apm:test-plan-7.10.0 label Oct 7, 2020

sorenlouv unassigned qn895 Oct 7, 2020

smith self-assigned this Oct 19, 2020

ogupte mentioned this pull request Oct 20, 2020

[APM] Fix service maps ML link remove zoom param #81091

Closed

smith added the apm:test-plan-done Pull request that was successfully tested during the test plan label Oct 21, 2020

smith removed their assignment Oct 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra #78209

[ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra #78209

qn895 commented Sep 22, 2020

jgowdyelastic left a comment

rylnd left a comment

rylnd Sep 30, 2020

qn895 Sep 30, 2020

kibanamachine commented Sep 30, 2020

kibanamachine commented Oct 2, 2020

smith commented Oct 21, 2020

[ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra #78209

[ML] Migrate machine learning URLs to BrowserRouter format for APM, Security, and Infra #78209

Conversation

qn895 commented Sep 22, 2020

Summary

Checklist

jgowdyelastic left a comment

Choose a reason for hiding this comment

rylnd left a comment

Choose a reason for hiding this comment

rylnd Sep 30, 2020

Choose a reason for hiding this comment

qn895 Sep 30, 2020

Choose a reason for hiding this comment

kibanamachine commented Sep 30, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

kibanamachine commented Oct 2, 2020

smith commented Oct 21, 2020