-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Add feature importance summary charts #78238
Merged
Merged
Changes from 22 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
f2b59b7
[ML] Add total summary charts for binary, multiclass (mock), and regr…
qn895 f14cae9
[ML] Remove mock data
qn895 c8dd714
[ML] Add formatting to 3 sig fig
qn895 255c5c3
[ML] Update LoadingPanel for when totalFeatureImportance
qn895 6820ab7
[ML] Add legend
qn895 2226e92
Merge remote-tracking branch 'upstream/master' into ml-feature-import…
qn895 8f18b98
[ML] Update comment for consistency
qn895 dc2538b
[ML] Only fetch inference model if regression or classification. Add …
qn895 bf2a837
Merge branch 'master' into ml-feature-importance-summary
elasticmachine f263a75
Merge remote-tracking branch 'upstream/master' into ml-feature-import…
qn895 c419c42
[ML] Adjust height, add i18n, only show legend of multiclass
qn895 fd279e4
[ML] Fix text
qn895 5ca3178
Merge remote-tracking branch 'upstream/master' into ml-feature-import…
qn895 6a3c0d8
[ML] Fix text & spacing
qn895 89f1ee3
[ML] Fix tooltip icon tip to match inline
qn895 25f8f83
Merge remote-tracking branch 'upstream/master' into ml-feature-import…
qn895 58fe66b
[ML] Update tooltipContent
qn895 e18bc41
[ML] Move to feature_importance type file, use util functions, remove cn
qn895 da48b1a
[ML] Sort order of class form smallest bottom to biggest top
qn895 3c4251f
[ML] Sort order of binary class form smallest bottom to biggest top
qn895 b73325b
[ML] Remove commented code
qn895 ab8a750
[ML] Rename total feature importance & hide numeric values for classi…
qn895 4c0abf5
Merge remote-tracking branch 'upstream/master' into ml-feature-import…
qn895 17cfd1d
[ML] Update legend for multi class total feature importance to look n…
qn895 701cbc2
Merge branch 'master' into ml-feature-importance-summary
elasticmachine File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit - I don't think you really need the
=== true
after theisArray
check as theisArray
method is pretty clear.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reasons TS needs the explicit check here to make the second part of the if statement valid. Not sure why but I will leave it for now if that's okay.