-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Secuirty Solution] Fixes alerts flaky test #78424
[Secuirty Solution] Fixes alerts flaky test #78424
Conversation
@elasticmachine merge upstream |
💛 Build succeeded, but was flaky
Test Failures"after each" hook for "inspects the Hosts Stat".Inspect Hosts stats and tables "after each" hook for "inspects the Hosts Stat"Stack Trace
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity: the behavior of should
is to retry until successful. .invoke('text').should('eq', expectedText)
has nothing to retry since it's a simple comparison with a static value, but .should('have.text', expectedText) and
.should(retryableCallback)` will perform retries.
Yes @rylnd you are completely right, this is why we are moving everything to that clause in refactors :) |
Co-authored-by: Elastic Machine <[email protected]>
Co-authored-by: Elastic Machine <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
Summary
The alerts spec started to be flaky and was skipped: #77957
In this PR we are fixing the flakiness modifying some of the code :)