Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Usage Collection] [schema] maps #78952

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

afharo
Copy link
Member

@afharo afharo commented Sep 30, 2020

Summary

  • Add more explicit TS definition for the maps collector (MapsUsage).
  • Add schema definition to the collector maps.

Using DYNAMIC_KEY as a way to tell when the key can be dynamic, and we can't know the possible values.

Related to #70180.

For maintainers

@afharo afharo added [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Team:KibanaTelemetry v7.10.0 labels Sep 30, 2020
Comment on lines +713 to +746
"layerTypesCount": {
"properties": {
"DYNAMIC_KEY": {
"properties": {
"min": {
"type": "long"
},
"max": {
"type": "long"
},
"avg": {
"type": "float"
}
}
}
}
},
"emsVectorLayersCount": {
"properties": {
"DYNAMIC_KEY": {
"properties": {
"min": {
"type": "long"
},
"max": {
"type": "long"
},
"avg": {
"type": "float"
}
}
}
}
}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as in #78832 @mindbat

@afharo afharo force-pushed the usage_collection/schema/maps branch from 9d17085 to ff12492 Compare September 30, 2020 13:31
@afharo afharo force-pushed the usage_collection/schema/maps branch from ff12492 to 749a53b Compare September 30, 2020 14:55
@afharo afharo marked this pull request as ready for review September 30, 2020 17:23
@afharo afharo requested review from a team as code owners September 30, 2020 17:23
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

Copy link
Contributor

@kindsun kindsun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code lgtm! Thanks for this @afharo 🙇 !

  • code review

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@afharo afharo merged commit bad59f4 into elastic:master Oct 1, 2020
@afharo afharo deleted the usage_collection/schema/maps branch October 1, 2020 14:16
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants