[SECURITY_SOLUTION] unskip tests after fixing Kibana and package #78954
Conversation
|
@kevinlog Remember to delete the metadata current archive you included for the UI test. |
|
@nnamdifrankie I updated the archive to point to the new index. I know that we're adding data directly to the new index as opposed to waiting for the transform, but I'd rather not have the really long sleeps in the tests since it expands the length of test runs for everyone. I think we'll need alternatives to testing the full flow from source index to destination. Perhaps a way to speed up execution of the transform for testing purposes. FYI @paul-tavares let us know your thoughts |
|
@elasticmachine merge upstream |
The benefit outweighs the cost for me. IT test are supposed to be relatively expensive. |
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kevinlog
added
release_note:skip
| @@ -85,17 +84,16 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |||
| }); | |||
|
|
|||
| it('finds data after load and polling', async () => { | |||
| await esArchiver.load('endpoint/metadata/api_feature', { useCreate: true }); | |||
| await pageObjects.endpoint.waitForTableToHaveData('endpointListTable', 100000); | |||
| await esArchiver.load('endpoint/metadata/destination_index', { useCreate: true }); | |||
There was a problem hiding this comment.
Hmm @nnamdifrankie is the index metrics-endpoint.metadata_current_default a data stream? If it is then this is fine. If it is not a data stream we should be able to omit the { useCreate: true } and we'd need to put the mapping file in the directory like we used to.
If the tests work like this though, I guess that's fine too 🤷
There was a problem hiding this comment.
@jonathan-buttner Well it works because we have an index template that matches the index, so you can search. I was curious about the useCreate here but I guess it did not make a difference. Ideally we should be using the transform e2e but it is expensive.
There was a problem hiding this comment.
@jonathan-buttner it's not a datastream. My guess on why the tests work is because the index gets created by the transform that's running. I can omit the useCreate to see what happens
There was a problem hiding this comment.
Na I wouldn't worry about it then. The only thing useCreate does is have es_archiver use create instead of index which means that it can't update a document.
There was a problem hiding this comment.
If it was a data stream you'd get an error if you didn't pass in useCreate
Summary
Re-enables the tests that we skipped due to the faulty endpoint package. When the Kibana changes and new package added, we're re-enabling the tests.
The are also some adjustments to the archive for the endpoint tests and some fixes for the Ingest tests in regards to the transform in the test package
This bug was the root cause of why the tests were failing ES promotion: #78024
Relevant issue where tests were skipped: #72102
Checklist
Delete any items that are not applicable to this PR.