Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] fix add new dimension button click area #79098

Closed
wants to merge 1 commit into from
Closed

[Lens] fix add new dimension button click area #79098

wants to merge 1 commit into from

Conversation

mbondyra
Copy link
Contributor

@mbondyra mbondyra commented Oct 1, 2020 •
edited
Loading

Summary

The 'drop a new field' button clickable area is quite small. This can cause accessibility problems and is not consistent with other dimension triggers clicking areas:

This PR solves it:

@mbondyra mbondyra requested a review from a team October 1, 2020 11:19
@mbondyra mbondyra added bug Fixes for quality problems that affect the customer experience Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0 labels Oct 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra added release_note:skip Skip the PR/issue when compiling release notes and removed bug Fixes for quality problems that affect the customer experience labels Oct 1, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
lens 998.0KB 998.5KB +537.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@cchaos
Copy link
Contributor

cchaos commented Oct 1, 2020

Hey @mbondyra I've actually already fixed this in #78674. Let's go with my PR since there will be conflicts if we try to do both

@mbondyra
Copy link
Contributor Author

mbondyra commented Oct 1, 2020

Sure @cchaos - next time please add me as a reviewer or kibana-app team so I get the notification.

@mbondyra mbondyra closed this Oct 1, 2020
@mbondyra mbondyra deleted the lens/fix_empty_trigger_button_area branch October 1, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cchaos cchaos Awaiting requested review from cchaos

@flash1293 flash1293 Awaiting requested review from flash1293

@wylieconlon wylieconlon Awaiting requested review from wylieconlon

@dej611 dej611 Awaiting requested review from dej611

Assignees
No one assigned
Labels
Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.10.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbondyra @elasticmachine @kibanamachine @cchaos