Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Storybook and Jest cleanup (#79305) #79544

Merged
merged 1 commit into from
Oct 5, 2020

Conversation

smith
Copy link
Contributor

@smith smith commented Oct 5, 2020

Backports the following commits to 7.x:

* Fix all broken stories
* Get rid of all Jest warnings
* Remove `@ts-expect-error`s added for JSON imports and fix their type errors
* Convert some stories to [Component Story Format](https://storybook.js.org/docs/react/api/csf)
* Replace story for Service Map with many external services with one for the popover with many external services
* Center and fit cytoscape maps in stories
* Rename some files to snake_case
@smith smith added the backport label Oct 5, 2020
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
apm 4.2MB 4.2MB +56.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@smith smith merged commit b183e6c into elastic:7.x Oct 5, 2020
@smith smith deleted the backport/7.x/pr-79305 branch October 5, 2020 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants