Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Resolver] Pills can overflow to the right #79734

Merged
merged 1 commit into from
Oct 6, 2020
Merged

[Security Solution][Resolver] Pills can overflow to the right #79734

merged 1 commit into from
Oct 6, 2020

Conversation

bkimmel
Copy link
Contributor

@bkimmel bkimmel commented Oct 6, 2020

Summary

This PR sets the style of pill boxes to allow long pills to overflow the container to the right side.

Screenshots:

(left is before, right is after)
image

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@bkimmel bkimmel added Team:Threat Hunting Security Solution Threat Hunting Team v7.10.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 6, 2020
@bkimmel bkimmel marked this pull request as ready for review October 6, 2020 18:03
@bkimmel bkimmel requested review from a team as code owners October 6, 2020 18:03
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
securitySolution 10.4MB 10.4MB +6.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@michaelolo24 michaelolo24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the issue for converting it to the concatenated form so we have it on deck for 7.11?

@bkimmel
Copy link
Contributor Author

bkimmel commented Oct 6, 2020

Can you make the issue for converting it to the concatenated form so we have it on deck for 7.11?

Thanks - I dropped it in the icebox

@bkimmel bkimmel merged commit 7068e96 into elastic:master Oct 6, 2020
@bkimmel bkimmel deleted the resolver/pill-allow-overflow-right branch October 6, 2020 20:42
bkimmel added a commit that referenced this pull request Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting Security Solution Threat Hunting Team v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants