Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes sorting of Alert Instance in Details page #80103

Merged
merged 2 commits into from
Oct 12, 2020

Conversation

gmmorris
Copy link
Contributor

@gmmorris gmmorris commented Oct 9, 2020

Summary

closes #80014

Sorts Alert instances by their status to ensure Active come first.

Screenshot 2020-10-09 at 12 29 46

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@gmmorris gmmorris requested a review from a team as a code owner October 9, 2020 11:30
@gmmorris gmmorris added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Oct 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@gmmorris
Copy link
Contributor Author

gmmorris commented Oct 9, 2020

Ideally we'd sort this on the server side, but as we don't so server side pagination and we return an object rather than an array, making that change here would be much bigger.

With that in mind this is a minimal 7.10 fix design to address the localized bug and we'll address the broader aspects of this once we align with Design on this.

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that approach for getting instances from API should be changed in the future releases, because having it as an object complicates a bunch of things (like sorting, filtering, pagination, etc.). At least we discussed example for Maps alerts where it could be thousands of instances and they were asking me about possibility to navigate throw them with filters and sorting. It would be awesome @gmmorris if you will create a follow up issues for this if we don't have yet.
But for 7.10 current quick fix is LGTM and works as expected locally.

@gmmorris
Copy link
Contributor Author

@elasticmachine merge upstream

@gmmorris
Copy link
Contributor Author

It would be awesome @gmmorris if you will create a follow up issues for this if we don't have yet.

I'm surprised I can't find an existing follow up issue for the Alerts Detail page. @mikecote any ideas? Am I missing an existing issue?

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

async chunks size

id before after diff
triggersActionsUi 1.5MB 1.5MB +337.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Copy link
Contributor

@ymao1 ymao1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gmmorris gmmorris merged commit 3bd95d4 into elastic:master Oct 12, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 12, 2020
Sorts Alert instances by their status to ensure Active come first.
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 12, 2020
Sorts Alert instances by their status to ensure Active come first.
@pmuellr
Copy link
Member

pmuellr commented Oct 12, 2020

merged before I could review :-) ; LGTM, tried it with my simulator bits, worked as expected

gmmorris added a commit that referenced this pull request Oct 12, 2020
Sorts Alert instances by their status to ensure Active come first.
gmmorris added a commit that referenced this pull request Oct 12, 2020
Sorts Alert instances by their status to ensure Active come first.
@mikecote
Copy link
Contributor

It would be awesome @gmmorris if you will create a follow up issues for this if we don't have yet.

I'm surprised I can't find an existing follow up issue for the Alerts Detail page. @mikecote any ideas? Am I missing an existing issue?

As discussed offline, there's no issue that I recall so worth opening one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting release_note:fix Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alert Instances aren't sorted correctly
7 participants