-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes sorting of Alert Instance in Details page #80103
fixes sorting of Alert Instance in Details page #80103
Conversation
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Ideally we'd sort this on the server side, but as we don't so server side pagination and we return an object rather than an array, making that change here would be much bigger. With that in mind this is a minimal 7.10 fix design to address the localized bug and we'll address the broader aspects of this once we align with Design on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that approach for getting instances from API should be changed in the future releases, because having it as an object complicates a bunch of things (like sorting, filtering, pagination, etc.). At least we discussed example for Maps alerts where it could be thousands of instances and they were asking me about possibility to navigate throw them with filters and sorting. It would be awesome @gmmorris if you will create a follow up issues for this if we don't have yet.
But for 7.10 current quick fix is LGTM and works as expected locally.
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorts Alert instances by their status to ensure Active come first.
Sorts Alert instances by their status to ensure Active come first.
merged before I could review :-) ; LGTM, tried it with my simulator bits, worked as expected |
As discussed offline, there's no issue that I recall so worth opening one. |
Summary
closes #80014
Sorts Alert instances by their status to ensure Active come first.
Checklist
Delete any items that are not applicable to this PR.
For maintainers