-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][Case] Manual attach alert to a case #82996
Conversation
0d763eb
to
4788048
Compare
b8f1ecd
to
c8e55c8
Compare
c8e55c8
to
1249e47
Compare
6be47ae
to
47b15f9
Compare
x-pack/plugins/security_solution/public/timelines/components/timeline/properties/index.tsx
Outdated
Show resolved
Hide resolved
...y_solution/public/detections/components/alerts_table/timeline_actions/alert_context_menu.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/use_all_cases_modal/index.test.tsx
Show resolved
Hide resolved
f13f32f
to
370198f
Compare
4962659
to
241765d
Compare
x-pack/plugins/security_solution/public/cases/containers/use_post_comment.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/containers/use_post_comment.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/add_comment/index.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/all_cases/index.tsx
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/all_cases/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/use_create_case_modal/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/security_solution/public/cases/components/use_create_case_modal/index.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do feel like the unit tests that you deleted are still valid and should stay in the repo.
Thanks! Which ones? |
df9b83f
to
812de1e
Compare
...ck/plugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.tsx
Outdated
Show resolved
Hide resolved
...ck/plugins/security_solution/public/cases/components/timeline_actions/add_to_case_action.tsx
Outdated
Show resolved
Hide resolved
0119c64
to
93ba1af
Compare
7080db3
to
39c42f0
Compare
💔 Build Failed
Failed CI StepsTest FailuresX-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/results/get_anomalies_table_data·ts.apis Machine Learning ResultsService GetAnomaliesTableData should fetch anomalies table dataStandard Out
Stack Trace
X-Pack API Integration Tests.x-pack/test/api_integration/apis/ml/results/get_anomalies_table_data·ts.apis Machine Learning ResultsService GetAnomaliesTableData should fetch anomalies table dataStandard Out
Stack Trace
Metrics [docs]Module Count
Async chunks
Distributable file count
Page load bundle
History
To update your PR or re-run it, just comment with: |
…k-field-to-hot-phase * 'master' of github.com:elastic/kibana: (429 commits) simplify popover open state logic (elastic#85379) [Logs UI][Metrics UI] Move actions to the kibana header (elastic#84648) [Search Source] Do not pick scripted fields if * provided (elastic#85133) [Search] Session SO polling (elastic#84225) [Transform] Replace legacy elasticsearch client (elastic#84932) [Uptime]Refactor header and action menu (elastic#83779) Fix agg select external link (elastic#85380) [ILM] Show forcemerge in hot when rollover is searchable snapshot is enabled (elastic#85292) clear using keyboard (elastic#85042) [GS] add tag and dashboard suggestion results (elastic#85144) [ML] API integration tests - skip GetAnomaliesTableData Add ECS field for event.code. (elastic#85109) [Functional][TSVB] Wait for markdown textarea to be cleaned (elastic#85128) skip flaky suite (elastic#62060) skip flaky suite (elastic#85098) Bump highlight.js to v9.18.5 (elastic#84296) Add `server.publicBaseUrl` config (elastic#85075) [Alerting & Actions ] More debug logging (elastic#85149) [Security Solution][Case] Manual attach alert to a case (elastic#82996) Loosen UUID regex to accept uuidv1 or uuidv4 (elastic#85338) ... # Conflicts: # x-pack/plugins/index_lifecycle_management/__jest__/client_integration/edit_policy/edit_policy.helpers.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/hot_phase/hot_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/shared_fields/index.ts # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/components/phases/warm_phase/warm_phase.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/edit_policy.tsx # x-pack/plugins/index_lifecycle_management/public/application/sections/edit_policy/i18n_texts.ts # x-pack/plugins/index_lifecycle_management/server/routes/api/policies/register_create_route.ts
Summary
This PR implements a feature in which a user can attach an alert to a case from the detection's engine alerts table. The user can either create a new case or select an existing case when attaching the alert.
Technical details:
usePostComment
hook does not take thecaseId
as an argument anymore.postComment
function takes an extra argumentcaseId
.onRowClick
function has been moved outside ofuseAllCasesModal
hook.all_cases_modal
folder has been deleted.Attach to a new case:
Attach to an existing case:
Depends on: #82405
Checklist
Delete any items that are not applicable to this PR.
For maintainers