[Security Solution] Gracefully handle errors in detection rules install

[pzl]

Summary

Gracefully handle errors that were getting missed.

fixes #83277

installPrepackagedRules returns an Array of promises (not a singular promise). Apparently, this does not sit well with Promise.all, and errors/exceptions in any member of that array are not appropriately caught, and result in an unhandled exception (no matter how many try/catches you wrap it in).

Instead, handing the Array right to Promise.all handles the errors just fine.

Also, typescript would not let me do:

await Promise.all([
    ...installPrepackagedRules(alertsClient, rulesToInstall, signalsIndex),
    installPrepackagedTimelines(maxTimelineImportExportSize, frameworkRequest, true),
])

because of argument type mismatches or something to that effect. Error looked like this: microsoft/TypeScript#35617

So it was pulled to the next line.

[elasticmachine]

Pinging @elastic/endpoint-app-team (Feature:Endpoint)

[pzl]

@elasticmachine merge upstream

[FrankHassanabad]

A lot of different authors in this file which kind of is what is making a few of the odd bugs and behaviors showing up.

installPrepackagedRules

That already returns an array so the code adding yet another array within an array is a problem. Glad you didn't do a spread here as that would just pull apart all of the array which isn't what you want.

This code should work as is. I will approve it.

[FrankHassanabad]

LGTM, this should work as it is laid out.

Side notes are we have a lot of authors and different ways of loading things at this point from one technique being auto-generating an index and then loading that with a require statement, and then some streams that are auto scanning directories and files on the system and loading from there.

It makes it a bit tricky to understand what is going on and validate the code is working as intended (has nothing to do with this PR though, this PR is 👍 ), just some general notes.

[FrankHassanabad]

@pzl , I changed the release not to be "fix" as this does fix a bug.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: b5588b3

Metrics [docs]

✅ unchanged

History

• 💚 Build #87657 succeeded c25ca88

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream