Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Metrics UI] Add basic interaction and shell for node details overlay (#82013) #83388

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

phillipb
Copy link
Contributor

Backports the following commits to 7.x:

…elastic#82013)

* Add basic interaction and shell for node details overlay

* Fix typecheck

* Remove context menu tests because context menu doesn't exist

* Remove outdated tests

* Remove unused variable

* Show the old overlay by default

* Fix typecheck

* Fix typo

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	x-pack/test/functional/apps/infra/feature_controls/infrastructure_security.ts
@phillipb
Copy link
Contributor Author

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1035 1039 +4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 2.5MB 2.5MB -1022.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@phillipb phillipb merged commit c9baaef into elastic:7.x Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants