adding mapLoaded event to tile_map visualization #8372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This isn't a blocker for 5.0.0 |
|
sorry ... its a blocker for the visualization detection in Reporting |
spalger
suggested changes
Sep 22, 2016
| @@ -116,14 +116,22 @@ export default function HandlerBaseClass(Private) { | |||
| }); | |||
|
|
|||
| // render the chart(s) | |||
| selection.selectAll('.chart') | |||
| .each(function (chartData) { | |||
| this.loadedCount = 0; | |||
There was a problem hiding this comment.
Do we need to expose this on this? I would rather it just be local variable.
| chart.events.on('rendered', () => { | ||
| self.loadedCount++; | ||
| if (self.loadedCount === chartSelection.length) { | ||
| charts[0].events.emit('renderComplete'); |
There was a problem hiding this comment.
Can you explain why this is using charts[0] in a comment in the code? I would expect this to happen at a higher level.
spalger
approved these changes
Sep 22, 2016
|
LGTM |
elastic-jasper
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** adding mapLoaded event to tile_map visualization * Original sha: e198f41 * Authored by ppisljar <[email protected]> on 2016-09-20T10:22:43Z **Commit 2:** adding rendered event to each chart and renderComplete to vis * Original sha: 8324f5a * Authored by ppisljar <[email protected]> on 2016-09-20T17:54:52Z **Commit 3:** fixing based on Spencers comments * Original sha: b4780fe * Authored by ppisljar <[email protected]> on 2016-09-22T07:24:19Z
elastic-jasper
added a commit
that referenced
this pull request
Sep 22, 2016
--------- **Commit 1:** adding mapLoaded event to tile_map visualization * Original sha: e198f41 * Authored by ppisljar <[email protected]> on 2016-09-20T10:22:43Z **Commit 2:** adding rendered event to each chart and renderComplete to vis * Original sha: 8324f5a * Authored by ppisljar <[email protected]> on 2016-09-20T17:54:52Z **Commit 3:** fixing based on Spencers comments * Original sha: b4780fe * Authored by ppisljar <[email protected]> on 2016-09-22T07:24:19Z
This was referenced Sep 22, 2016
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
--------- **Commit 1:** adding mapLoaded event to tile_map visualization * Original sha: 0f673d7c14ee9fa638b7f284f5254ef570f17c93 [formerly e198f41] * Authored by ppisljar <[email protected]> on 2016-09-20T10:22:43Z **Commit 2:** adding rendered event to each chart and renderComplete to vis * Original sha: 39530305081240930e33369de64db51fd68e7fc5 [formerly 8324f5a] * Authored by ppisljar <[email protected]> on 2016-09-20T17:54:52Z **Commit 3:** fixing based on Spencers comments * Original sha: fabc53d93bde22909ee696a5d18ce21434e0d638 [formerly b4780fe] * Authored by ppisljar <[email protected]> on 2016-09-22T07:24:19Z Former-commit-id: c064f87
airow
pushed a commit
to airow/kibana
that referenced
this pull request
Feb 16, 2017
[backport] PR elastic#8372 to 5.x Former-commit-id: 4752dbb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding mapLoaded event to tile_map visualization.
update: i added rendered event to each chart and renderComplete event which is fired once all the charts have been rendered.
we can now attach listener to Vis